Re: [PATCH V5 2/9] Add Synopsys DesignWare HS USB OTG driver framework.

2010-10-21 Thread Alan Cox
> + int retval = IRQ_NONE; > + > + retval = dwc_otg_handle_common_intr(dwc_dev->core_if); > + return IRQ_RETVAL(retval); Why assign retval first ? > +} > + > +/** > + * This function is the interrupt handler for the OverCurrent condition > + * from the external charge pump (if enabled

Re: [PATCH V5 2/9] Add Synopsys DesignWare HS USB OTG driver framework.

2010-10-20 Thread Felipe Balbi
On Wed, Oct 20, 2010 at 07:42:45PM -0500, Fushen Chen wrote: Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc_otg/dwc_otg_apmppc.c | 394 ++ drive

[PATCH V5 2/9] Add Synopsys DesignWare HS USB OTG driver framework.

2010-10-20 Thread Fushen Chen
Platform probing is in dwc_otg_apmppc.c. Driver parameter and parameter checking are in dwc_otg_param.c. Signed-off-by: Fushen Chen Signed-off-by: Mark Miesfeld --- drivers/usb/dwc_otg/dwc_otg_apmppc.c | 394 ++ drivers/usb/dwc_otg/dwc_otg_driver.h | 78 drivers/usb/dwc_