Re: [PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-20 Thread Vaibhav Jain
christophe lombard writes: > Le 20/12/2017 à 09:46, Vaibhav Jain a écrit : >>> In fact, it does not matter. I don't know what the userspace could do >>> with this value. >> Without libcxl knowing the tidr value, it cannot enforce the condition >> that only threads that have called attach can issu

Re: [PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-20 Thread christophe lombard
Le 20/12/2017 à 09:46, Vaibhav Jain a écrit : Hi Chritophe, christophe lombard writes: Le 20/12/2017 à 07:31, Vaibhav Jain a écrit : EINVAL might be a better return value instead of ENODEV in this case. This return code has been already discussed (with mpe) on the first version of the patc

Re: [PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-20 Thread Vaibhav Jain
Hi Chritophe, christophe lombard writes: > Le 20/12/2017 à 07:31, Vaibhav Jain a écrit : >> EINVAL might be a better return value instead of ENODEV in this case. > > This return code has been already discussed (with mpe) on the first > version of the patch. "Either ENODEV or ENXIO would be best

Re: [PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-20 Thread christophe lombard
Le 20/12/2017 à 07:31, Vaibhav Jain a écrit : Hi Christophe, Thanks for the changes to the patch. Few minor review comments: Thanks for the review. Christophe Lombard writes: @@ -362,3 +363,17 @@ void cxl_context_mm_count_put(struct cxl_context *ctx) if (ctx->mm)

Re: [PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-19 Thread Vaibhav Jain
Hi Christophe, Thanks for the changes to the patch. Few minor review comments: Christophe Lombard writes: > @@ -362,3 +363,17 @@ void cxl_context_mm_count_put(struct cxl_context *ctx) > if (ctx->mm) > mmdrop(ctx->mm); > } > + > +int cxl_context_thread_tidr(struct cxl_contex

[PATCH V4] cxl: Add support for ASB_Notify on POWER9

2017-12-19 Thread Christophe Lombard
The POWER9 core supports a new feature: ASB_Notify which requires the support of the Special Purpose Register: TIDR. The ASB_Notify command, generated by the AFU, will attempt to wake-up the host thread identified by the particular LPID:PID:TID. This patch assign a unique TIDR (thread id) for the