Re: [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

2009-05-25 Thread Jon Smirl
On Mon, May 25, 2009 at 2:34 AM, Grant Likely wrote: > On Sun, May 24, 2009 at 7:38 PM, Jon Smirl wrote: > > This is ugly.  I'd really rather have a generic mechanism for creating > a fabric driver based on the OF data.  But failing that, it seems to > me that this platform device registration sh

Re: [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

2009-05-25 Thread Mark Brown
On Sun, May 24, 2009 at 09:38:51PM -0400, Jon Smirl wrote: > +static __exit void pcm030_fabric_exit(void) > +{ > +} Remove or implement, please. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

2009-05-25 Thread Mark Brown
On Mon, May 25, 2009 at 12:34:57AM -0600, Grant Likely wrote: > This is ugly. I'd really rather have a generic mechanism for creating > a fabric driver based on the OF data. But failing that, it seems to > me that this platform device registration should be done in the > platform code (arch/powe

Re: [PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

2009-05-24 Thread Grant Likely
On Sun, May 24, 2009 at 7:38 PM, Jon Smirl wrote: > Support for AC97 on Phytec pmc030 base board. A wm9712 AC97 codec is used. > > Signed-off-by: Jon Smirl > --- >  sound/soc/fsl/Kconfig               |    7 +++ >  sound/soc/fsl/Makefile              |    3 + >  sound/soc/fsl/pcm030-audio-fabric.

[PATCH V3 3/4] Support for AC97 on Phytec pmc030 base board.

2009-05-24 Thread Jon Smirl
Support for AC97 on Phytec pmc030 base board. A wm9712 AC97 codec is used. Signed-off-by: Jon Smirl --- sound/soc/fsl/Kconfig |7 +++ sound/soc/fsl/Makefile |3 + sound/soc/fsl/pcm030-audio-fabric.c | 95 +++ 3 files changed, 1