Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-08-01 Thread Joakim Tjernlund
> > > On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > > > We unified the Freescale pci/pcie initialization by changing the fsl_pci > > to a platform driver. In previous PCI code architecture the initialization > > routine is called at board_setup_arch stage. Now the initialization is done > > in

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Jia Hongtao-B38951
;>> > >>> > >>>> -Original Message- > >>>> From: Kumar Gala [mailto:ga...@kernel.crashing.org] > >>>> Sent: Saturday, July 28, 2012 5:17 AM > >>>> To: Wood Scott-B07421 > >>>> Cc: Jia Hongtao-B3895

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Kumar Gala
la [mailto:ga...@kernel.crashing.org] >>>> Sent: Saturday, July 28, 2012 5:17 AM >>>> To: Wood Scott-B07421 >>>> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; >>>> Li Yang-R58472 >>>> Subject: Re: [PATCH V

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-31 Thread Li Yang
AM >>> To: Wood Scott-B07421 >>> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; >>> Li Yang-R58472 >>> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >>> initialization code >>> >>> >>>

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
To: Wood Scott-B07421 > >> Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott- > B07421; > >> Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >>

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
51 > >> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >> On Jul 27, 2012, at 3:35 AM, Jia Hongtao-B38951 wrote: > >>

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Kumar Gala
ozlabs.org; Wood Scott-B07421; >> Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 27, 2012, at 3:24 PM, Scott Wood wrote: >> >>> On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wr

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Kumar Gala
Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 27, 2012, at 3:35 AM, Jia Hongtao-B38951 wrote: >> >>> >>> >>>> -Original Message- >>>> From:

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Saturday, July 28, 2012 5:17 AM > To: Wood Scott-B07421 > Cc: Jia Hongtao-B38951; linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; > Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] power

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-30 Thread Jia Hongtao-B38951
Jia Hongtao-B38951 > >> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > >> initialization code > >> > >> > >> On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: &g

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Kumar Gala
On Jul 27, 2012, at 3:24 PM, Scott Wood wrote: > On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wrote: >> Hi kumar, >> >> I know "duplicate code from pci_process_bridge_OF_ranges()" is >> hard to accept but "refactor the code to have a shared function" >> is knotty. Actually this is the reason I did

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Scott Wood
On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wrote: > Hi kumar, > > I know "duplicate code from pci_process_bridge_OF_ranges()" is > hard to accept but "refactor the code to have a shared function" > is knotty. Actually this is the reason I didn't do the refactor. Maybe we should keep doing the ini

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Kumar Gala
tt-B07421; Li Yang-R58472 >> Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie >> initialization code >> >> >> On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: >> >>> We unified the Freescale pci/pcie initialization by changing the >> fs

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Jia Hongtao-B38951
iginal Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, July 27, 2012 1:53 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie > initializ

RE: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-27 Thread Jia Hongtao-B38951
> -Original Message- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, July 27, 2012 2:15 AM > To: Jia Hongtao-B38951 > Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472 > Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pci

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Kumar Gala
On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Kumar Gala
On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote: > We unified the Freescale pci/pcie initialization by changing the fsl_pci > to a platform driver. In previous PCI code architecture the initialization > routine is called at board_setup_arch stage. Now the initialization is done > in probe function

[PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code

2012-07-26 Thread Jia Hongtao
We unified the Freescale pci/pcie initialization by changing the fsl_pci to a platform driver. In previous PCI code architecture the initialization routine is called at board_setup_arch stage. Now the initialization is done in probe function which is architectural better. Also It's convenient for a