Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-28 Thread Grant Likely
On Wed, Aug 26, 2009 at 11:46 PM, Benjamin Herrenschmidt wrote: > On Wed, 2009-08-26 at 00:07 -0600, Grant Likely wrote: >> From: Grant Likely >> >> The two versions are doing almost exactly the same thing.  No need to >> maintain them as separate files.  This patch also has the side effect >> of

Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-26 Thread Benjamin Herrenschmidt
On Wed, 2009-08-26 at 00:07 -0600, Grant Likely wrote: > From: Grant Likely > > The two versions are doing almost exactly the same thing. No need to > maintain them as separate files. This patch also has the side effect > of making the PCI device tree scanning code available to 32 bit powerpc >

Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-26 Thread Grant Likely
On Wed, Aug 26, 2009 at 7:29 AM, Kumar Gala wrote: > > On Aug 26, 2009, at 1:07 AM, Grant Likely wrote: > >> +/** >> + * pci_scan_phb - Given a pci_controller, setup and scan the PCI bus >> + * @hose: Pointer to the PCI host controller instance structure >> + * @data: value to use for sysdata point

Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-26 Thread Kumar Gala
On Aug 26, 2009, at 1:07 AM, Grant Likely wrote: +/** + * pci_scan_phb - Given a pci_controller, setup and scan the PCI bus + * @hose: Pointer to the PCI host controller instance structure + * @data: value to use for sysdata pointer. ppc32 and ppc64 differ here + * + * Note: the 'data' poin

[PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-25 Thread Grant Likely
From: Grant Likely The two versions are doing almost exactly the same thing. No need to maintain them as separate files. This patch also has the side effect of making the PCI device tree scanning code available to 32 bit powerpc machines, but no board ports actually make use of this feature at