Re: [PATCH V2 1/2] ASoC: fsl_asrc: replace the process_option table with function

Hi > > > On Thu, Apr 11, 2019 at 09:39:06AM +, S.j. Wang wrote: > > > +/* > > + * Select the pre-processing and post-processing options > > By aligning with other function comments: > /** > * Select the pre-processing and post-processing options > > > + * > > + * Fsin: input sample rate

Re: [PATCH V2 1/2] ASoC: fsl_asrc: replace the process_option table with function

On Thu, Apr 11, 2019 at 09:39:06AM +, S.j. Wang wrote: > +/* > + * Select the pre-processing and post-processing options By aligning with other function comments: /** * Select the pre-processing and post-processing options > + * > + * Fsin: input sample rate > + * Fsout: output sample rat

Re: [PATCH V2 1/2] ASoC: fsl_asrc: replace the process_option table with function

Hi Shengjiu, Mostly looking good. See few comments inline: > +/* > + * Select the pre-processing and post-processing options > + * > + * Fsin: input sample rate > + * Fsout: output sample rate > + * pre_proc: return value for pre-processing option > + * post_proc: return value for post-processi

[PATCH V2 1/2] ASoC: fsl_asrc: replace the process_option table with function

When we want to support more sample rate, for example 12kHz/24kHz we need update the process_option table, if we want to support more sample rate next time, the table need to be updated again. which is not flexible. We got a function fsl_asrc_sel_proc to replace the table, which can give the pre-p