Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-19 Thread Alexander Popov
2013/11/15 Gerhard Sittig : > As for the not yet addressed feedback: From the top of my head I > can think of the execute comment which contradicts the code > (which suggests that at least one of them is wrong), and the data > type mismatch in the config routine (where code just happens to > work

Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-14 Thread Gerhard Sittig
On Tue, Nov 12, 2013 at 16:23 +0400, Alexander Popov wrote: > > 2013/11/12 Gerhard Sittig : > > > > It would be nice to get a response to the feedback that you > > are given. It may be appropriate not to obey to the > > feedback, but at least it should get considered. > > Yes, I see. My implici

Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-12 Thread Alexander Popov
Hello, Gerhard! 2013/11/12 Gerhard Sittig : > Alexander, there is outstanding review feedback for a previous > version of the series that you haven't addressed yet. Can you > please either look into those issues, or state that it's OK to > leave them and why this is so? Excuse me for misunderstan

Re: [PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-11 Thread Gerhard Sittig
On Fri, Nov 01, 2013 at 11:19 +0400, Alexander Popov wrote: > > Introduce support for slave s/g transfer preparation and the associated > device control callback in the MPC512x DMA controller driver, which adds > support for data transfers between memory and peripheral I/O to the > previously supp

[PATCH RFC v5 2/5] dma: mpc512x: add support for peripheral transfers

2013-11-01 Thread Alexander Popov
Introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers. Signed-off-by: Alexander Popov --- drive