Re: [PATCH RFC v5] net: add PCINet driver

2009-01-16 Thread Jan-Bernd Themann
Hi! Ira Snyder wrote on 15.01.2009 22:40:56: > On Thu, Jan 15, 2009 at 10:22:53PM +0100, Arnd Bergmann wrote: > > On Thursday 15 January 2009, Ira Snyder wrote: > > > I have another question for you Arnd. > > > > > > What did you use as the host and guest drivers when you ran virtio over > > >

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 11:53:24PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > I do have mailboxes (two inbound, two outbound) which can generate > > interrupts, as well as doorbell registers (one inbound, one outbound). > > The doorbell register's bits are "wri

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 09:57:41PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > Some sort of Broadcom chipset, I think. Full dmesg and lspci output are > > appended. > > > > The PCI bridge does mention MSI, so maybe it does support it. Would > > using the DMA fr

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Arnd Bergmann
On Thursday 15 January 2009, Ira Snyder wrote: > I do have mailboxes (two inbound, two outbound) which can generate > interrupts, as well as doorbell registers (one inbound, one outbound). > The doorbell register's bits are "write 1 to clear", and can only be > cleared by the opposite side. > Ok,

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 10:22:53PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > I have another question for you Arnd. > > > > What did you use as the host and guest drivers when you ran virtio over > > PCI? Did you use two unmodified instances of virtio_net (one

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Arnd Bergmann
On Thursday 15 January 2009, Ira Snyder wrote: > I have another question for you Arnd. > > What did you use as the host and guest drivers when you ran virtio over > PCI? Did you use two unmodified instances of virtio_net (one on host, > one on guest) for networking, or did you write new virtio dri

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Arnd Bergmann
On Thursday 15 January 2009, Ira Snyder wrote: > Some sort of Broadcom chipset, I think. Full dmesg and lspci output are > appended. > > The PCI bridge does mention MSI, so maybe it does support it. Would > using the DMA from the host mean that the guest system couldn't use the > DMA controller at

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 06:53:51PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > > > These are PCI boards, not PCIe. The host computers are all Pentium3-M > > systems. I tried enabling MSI on the Freescale boards in the driver, by > > calling pci_enable_msi() dur

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 06:53:51PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > > > These are PCI boards, not PCIe. The host computers are all Pentium3-M > > systems. I tried enabling MSI on the Freescale boards in the driver, by > > calling pci_enable_msi() dur

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Arnd Bergmann
On Thursday 15 January 2009, Ira Snyder wrote: > > These are PCI boards, not PCIe. The host computers are all Pentium3-M > systems. I tried enabling MSI on the Freescale boards in the driver, by > calling pci_enable_msi() during probe(), and it failed. That doesn't really mean anything, just tha

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Ira Snyder
On Thu, Jan 15, 2009 at 01:58:33PM +0100, Arnd Bergmann wrote: > On Thursday 15 January 2009, Ira Snyder wrote: > > > The only problem with that is that you cannot route interrupts from the > > DMA controller over PCI with the PowerPC core running. Which makes it > > mostly useless for this case.

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-15 Thread Arnd Bergmann
On Thursday 15 January 2009, Ira Snyder wrote: > The only problem with that is that you cannot route interrupts from the > DMA controller over PCI with the PowerPC core running. Which makes it > mostly useless for this case. If the host supports MSI, you can simply program the DMA controller to w

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-14 Thread Ira Snyder
On Tue, Jan 13, 2009 at 06:42:53PM +0100, Arnd Bergmann wrote: > On Tuesday 13 January 2009, Ira Snyder wrote: > > So do you program one channel of the DMA engine from the host side and > > another channel from the guest side? > > Yes. > > > I tried to avoid having the host program the DMA contro

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-13 Thread Arnd Bergmann
On Tuesday 13 January 2009, Ira Snyder wrote: > So do you program one channel of the DMA engine from the host side and > another channel from the guest side? Yes. > I tried to avoid having the host program the DMA controller at all. > Using the DMAEngine API on the guest did better than I could a

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-13 Thread Ira Snyder
On Tue, Jan 13, 2009 at 05:33:03PM +0100, Arnd Bergmann wrote: > On Tuesday 13 January 2009, Ira Snyder wrote: > > On Tue, Jan 13, 2009 at 01:02:52PM +1030, Rusty Russell wrote: > > > > > >Interesting system: the guest being able to access the > > >host's memory but not (fully) vice-versa

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-13 Thread Arnd Bergmann
On Tuesday 13 January 2009, Ira Snyder wrote: > On Tue, Jan 13, 2009 at 01:02:52PM +1030, Rusty Russell wrote: > > > >Interesting system: the guest being able to access the > >host's memory but not (fully) vice-versa makes this a > >little different from the current implementations whe

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-12 Thread Ira Snyder
On Tue, Jan 13, 2009 at 01:02:52PM +1030, Rusty Russell wrote: > On Friday 09 January 2009 08:21:27 Ira Snyder wrote: > > Rusty, since you wrote the virtio code, can you point me at the things I > > would need to implement to use virtio over the PCI bus. > > > > The guests (PowerPC computers runni

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-12 Thread Rusty Russell
On Friday 09 January 2009 08:21:27 Ira Snyder wrote: > Rusty, since you wrote the virtio code, can you point me at the things I > would need to implement to use virtio over the PCI bus. > > The guests (PowerPC computers running Linux) are PCI cards in the host > system (an Intel Pentium3-M system)

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-12 Thread Arnd Bergmann
On Sunday 11 January 2009, Benjamin Herrenschmidt wrote: > On Thu, 2009-01-08 at 13:51 -0800, Ira Snyder wrote: > > The guests (PowerPC computers running Linux) are PCI cards in the host > > system (an Intel Pentium3-M system). The guest computers can access all > > of the host's memory. The guests

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-10 Thread Benjamin Herrenschmidt
On Thu, 2009-01-08 at 13:51 -0800, Ira Snyder wrote: > The guests (PowerPC computers running Linux) are PCI cards in the host > system (an Intel Pentium3-M system). The guest computers can access all > of the host's memory. The guests provide a 1MB (movable) window into > their memory. > > The Pow

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread Ira Snyder
On Thu, Jan 08, 2009 at 11:27:16AM -0800, Ira Snyder wrote: > On Thu, Jan 08, 2009 at 11:16:10AM -0800, David Miller wrote: > > From: Ira Snyder > > Date: Wed, 7 Jan 2009 11:50:52 -0800 > > > > > This adds support to Linux for a virtual ethernet interface which uses the > > > PCI bus as its trans

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread Ira Snyder
On Thu, Jan 08, 2009 at 11:16:10AM -0800, David Miller wrote: > From: Ira Snyder > Date: Wed, 7 Jan 2009 11:50:52 -0800 > > > This adds support to Linux for a virtual ethernet interface which uses the > > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > > method of co

Re: [PATCH RFC v5] net: add PCINet driver

2009-01-08 Thread David Miller
From: Ira Snyder Date: Wed, 7 Jan 2009 11:50:52 -0800 > This adds support to Linux for a virtual ethernet interface which uses the > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > method of communication for two devices connected by a PCI interface. Well, it looks