Re: [PATCH RFC v2] net: add PCINet driver

2008-11-05 Thread Ira Snyder
On Wed, Nov 05, 2008 at 02:50:59PM +0100, Arnd Bergmann wrote: > On Tuesday 04 November 2008, Ira Snyder wrote: > > On Tue, Nov 04, 2008 at 09:23:03PM +0100, Arnd Bergmann wrote: > > > On Tuesday 04 November 2008, Ira Snyder wrote: > > > > I don't really know how to do that. I got a warning here fr

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-05 Thread Ira Snyder
On Wed, Nov 05, 2008 at 02:19:52PM +0100, Arnd Bergmann wrote: > On Tuesday 04 November 2008, Ira Snyder wrote: > > > So, since interrupts are disabled while my interrupt handler is running, > > I think I should be able to use spin_lock() and spin_unlock(), correct? > > yes. > > > But sparse giv

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-05 Thread Arnd Bergmann
On Tuesday 04 November 2008, Ira Snyder wrote: > On Tue, Nov 04, 2008 at 09:23:03PM +0100, Arnd Bergmann wrote: > > On Tuesday 04 November 2008, Ira Snyder wrote: > > > I don't really know how to do that. I got a warning here from sparse > > > telling me something about expensive pointer subtractio

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-05 Thread Arnd Bergmann
On Tuesday 04 November 2008, Ira Snyder wrote: > So, since interrupts are disabled while my interrupt handler is running, > I think I should be able to use spin_lock() and spin_unlock(), correct? yes. > But sparse gives me the following warning: > wqt.c:185:9: warning: context imbalance in 'wqt_

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-04 Thread Ira Snyder
On Tue, Nov 04, 2008 at 09:23:03PM +0100, Arnd Bergmann wrote: Big snip. > > > > I tried to make the locking do only what was needed. I just couldn't get > > it correct unless I used spin_lock_irqsave(). I was able to get the > > system to deadlock otherwise. This is why I posted the driver for

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-04 Thread Ira Snyder
On Tue, Nov 04, 2008 at 09:23:03PM +0100, Arnd Bergmann wrote: > On Tuesday 04 November 2008, Ira Snyder wrote: > > On Tue, Nov 04, 2008 at 01:09:25PM +0100, Arnd Bergmann wrote: > > > > > > Why 'depends on !PCI'? This means that you cannot build a kernel that > > > is able to run both as host and

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-04 Thread Arnd Bergmann
On Tuesday 04 November 2008, Ira Snyder wrote: > On Tue, Nov 04, 2008 at 01:09:25PM +0100, Arnd Bergmann wrote: > > > > Why 'depends on !PCI'? This means that you cannot build a kernel that > > is able to run both as host and endpoint for PCInet, right? > > > > Yes, that is correct. I did this be

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-04 Thread Ira Snyder
On Tue, Nov 04, 2008 at 01:09:25PM +0100, Arnd Bergmann wrote: > On Wednesday 29 October 2008, Ira Snyder wrote: > > This adds support to Linux for a virtual ethernet interface which uses the > > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > > method of communication

Re: [PATCH RFC v2] net: add PCINet driver

2008-11-04 Thread Arnd Bergmann
On Wednesday 29 October 2008, Ira Snyder wrote: > This adds support to Linux for a virtual ethernet interface which uses the > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > method of communication for two devices connected by a PCI interface. Very interesting. I hav

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Matt Sealey
Ira Snyder wrote: I'll go ahead change the typedef to a struct. Hopefully some of the other inspiration I took wasn't too bad. I'm totally open to suggestions on improvements for this driver. Not a suggestion for improvement, but I have to say this is by far the single coolest thing I have E

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Ira Snyder
On Wed, Oct 29, 2008 at 03:54:46PM -0500, Scott Wood wrote: > Ira Snyder wrote: >> I know about this. I was following the example set forth in >> drivers/net/fs_enet. > > I recommend against that. :-) Great, now you tell me :) I'll go ahead change the typedef to a struct. Hopefully some of the o

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Scott Wood
Ira Snyder wrote: I know about this. I was following the example set forth in drivers/net/fs_enet. I recommend against that. :-) -Scott ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Ira Snyder
On Wed, Oct 29, 2008 at 01:25:06PM -0700, Stephen Hemminger wrote: > On Wed, 29 Oct 2008 13:20:27 -0700 > Ira Snyder <[EMAIL PROTECTED]> wrote: Big snip... > > diff --git a/drivers/net/pcinet.h b/drivers/net/pcinet.h > > new file mode 100644 > > index 000..66d2cba > > --- /dev/null > > +++ b/

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Stephen Hemminger
On Wed, 29 Oct 2008 13:20:27 -0700 Ira Snyder <[EMAIL PROTECTED]> wrote: > This adds support to Linux for a virtual ethernet interface which uses the > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > method of communication for two devices connected by a PCI interface