Re: [PATCH RFC 18/29] mm: remove __folio_test_movable()

2025-06-30 Thread David Hildenbrand
@@ -1164,7 +1148,6 @@ static int migrate_folio_unmap(new_folio_t get_new_folio, int rc = -EAGAIN; int old_page_state = 0; struct anon_vma *anon_vma = NULL; - bool is_lru = data_race(!__folio_test_movable(src)); bool locked = false; bool dst_locked = fa

Re: [PATCH RFC 18/29] mm: remove __folio_test_movable()

2025-06-20 Thread Zi Yan
On 18 Jun 2025, at 13:40, David Hildenbrand wrote: > Convert to page_has_movable_ops(). While at it, cleanup relevant code > a bit. > > The data_race() in migrate_folio_unmap() is questionable: we already > hold a page reference, and concurrent modifications can no longer > happen (iow: __ClearPag

[PATCH RFC 18/29] mm: remove __folio_test_movable()

2025-06-18 Thread David Hildenbrand
Convert to page_has_movable_ops(). While at it, cleanup relevant code a bit. The data_race() in migrate_folio_unmap() is questionable: we already hold a page reference, and concurrent modifications can no longer happen (iow: __ClearPageMovable() no longer exists). Drop it for now, we'll rework pag