Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-13 Thread Alan Cox
On Mon, 13 Oct 2008 16:17:02 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > Wang Jian wrote: > > +static void pata_platform_postreset(struct ata_link *link, unsigned int > > *classes) > > +{ > > + struct ata_port *ap = link->ap; > > + struct ata_device *dev; > > + u8 select = ATA_

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-13 Thread Tejun Heo
Wang Jian wrote: > Tejun Heo wrote: >> Hello, >> >> Wang Jian wrote: >>> +static void pata_platform_postreset(struct ata_link *link, unsigned >>> int *classes) >>> +{ >>> +struct ata_port *ap = link->ap; >>> +struct ata_device *dev; >>> +u8 select = ATA_DEVICE_OBS; >>> + >>> +/* Cal

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-13 Thread Wang Jian
Tejun Heo wrote: Hello, Wang Jian wrote: +static void pata_platform_postreset(struct ata_link *link, unsigned int *classes) +{ + struct ata_port *ap = link->ap; + struct ata_device *dev; + u8 select = ATA_DEVICE_OBS; + + /* Call default callback first */ + ata_sff

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-13 Thread Tejun Heo
Hello, Wang Jian wrote: > +static void pata_platform_postreset(struct ata_link *link, unsigned int > *classes) > +{ > + struct ata_port *ap = link->ap; > + struct ata_device *dev; > + u8 select = ATA_DEVICE_OBS; > + > + /* Call default callback first */ > + ata_sff_postreset(l

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-11 Thread Wang Jian
Benjamin Herrenschmidt 写道: > On Sun, 2008-10-12 at 02:00 +0800, Wang Jian wrote: >> To avoid adding another rare used ata_port member, new bit is added to >> ata_port->flags. >> >> Originally, I hacked pata_platform to make it 8bit only to support 8bit >> data wired CF card. This patch is more gene

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-11 Thread Benjamin Herrenschmidt
On Sun, 2008-10-12 at 02:00 +0800, Wang Jian wrote: > To avoid adding another rare used ata_port member, new bit is added to > ata_port->flags. > > Originally, I hacked pata_platform to make it 8bit only to support 8bit > data wired CF card. This patch is more generic. > > With this patch, __pata

[PATCH RFC] pata_platform: add 8 bit data io support

2008-10-11 Thread Wang Jian
To avoid adding another rare used ata_port member, new bit is added to ata_port->flags. Originally, I hacked pata_platform to make it 8bit only to support 8bit data wired CF card. This patch is more generic. With this patch, __pata_platform_probe() interface is changed, and pata_of_platform is br