Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-18 Thread Benjamin Herrenschmidt
On Wed, 2015-02-18 at 08:30 -0600, Bjorn Helgaas wrote: > > So the hypervisor call that removes the device from the partition will > fail if there are any translations that reference the memory of the > device. > > Let me go through this in excruciating detail to see if I understand > what's goin

Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-18 Thread Bjorn Helgaas
[+cc linux-mm, linux-kernel] For context, the start of this discussion was here: http://lkml.kernel.org/r/1424157203-691-8-git-send-email-gws...@linux.vnet.ibm.com where Gavin is adding a new PCI hotplug driver for PowerNV. That new driver calls vm_unmap_aliases() the same way we do in the existi

Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-17 Thread Benjamin Herrenschmidt
On Wed, 2015-02-18 at 11:16 +1100, Gavin Shan wrote: > >What is vm_unmap_aliases() for? I see this is probably copied from > >rpaphp_core.c, where it was added by b4a26be9f6f8 ("powerpc/pseries: > Flush > >lazy kernel mappings after unplug operations"). > > > >But I don't know whether: > > > > -

Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-17 Thread Gavin Shan
On Tue, Feb 17, 2015 at 04:09:16PM -0600, Bjorn Helgaas wrote: >On Tue, Feb 17, 2015 at 06:13:23PM +1100, Gavin Shan wrote: >> The patch intends to add standalone driver to support PCI hotplug >> for PowerPC PowerNV platform, which runs on top of skiboot firmware. >> The firmware identified hotplug

Re: [PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-17 Thread Bjorn Helgaas
On Tue, Feb 17, 2015 at 06:13:23PM +1100, Gavin Shan wrote: > The patch intends to add standalone driver to support PCI hotplug > for PowerPC PowerNV platform, which runs on top of skiboot firmware. > The firmware identified hotpluggable slots and marked their device > tree node with proper "ibm,sl

[PATCH RESEND v2 7/7] PCI/hotplug: PowerPC PowerNV PCI hotplug driver

2015-02-16 Thread Gavin Shan
The patch intends to add standalone driver to support PCI hotplug for PowerPC PowerNV platform, which runs on top of skiboot firmware. The firmware identified hotpluggable slots and marked their device tree node with proper "ibm,slot-pluggable" and "ibm,reset-by-firmware". The driver simply scans d