Re: [PATCH 7/8] pseries: phyp dump: Unregister and print dump areas.

2008-01-08 Thread Manish Ahuja
Stephen, >> +/* Add addr value if not initialized before */ >> +if (ph->cpu_data.destination_address == 0) { >> +ph->cpu_data.destination_address += addr; > > Could be just '=' like further down, right? Actually the one below should be += as well. Thanks for catching it. >>

Re: [PATCH 7/8] pseries: phyp dump: Unregister and print dump areas.

2008-01-07 Thread Stephen Rothwell
Hi Manish, Just more trivial stuff. On Mon, 07 Jan 2008 18:37:31 -0600 Manish Ahuja <[EMAIL PROTECTED]> wrote: > > static void register_dump_area(struct phyp_dump_header *ph, unsigned long > addr) > { > int rc; > - ph->cpu_data.destination_address += addr; > - ph->hpte_data.desti

[PATCH 7/8] pseries: phyp dump: Unregister and print dump areas.

2008-01-07 Thread Manish Ahuja
Routines to invalidate and unregister dump routines. Unregister has not been used yet, I will release another patch for that at a later stage with the kdump integration patches. There is also a routine which calculates the regions to be freed and exports that through sysfs. Signed-off-by: Manis