On Wed, 9 Jan 2008 14:16:49 +1100 Stephen Rothwell <[EMAIL PROTECTED]> wrote:
>
> On Tue, 8 Jan 2008 09:01:33 -0700 John Rigby <[EMAIL PROTECTED]> wrote:
> >
> > +++ b/drivers/serial/mpc512x_uart.c
> >
> > +#include
>
> Purely to avoid suggestions of favouritism, I will not the above. :-)
On Tue, 8 Jan 2008 09:01:33 -0700 John Rigby <[EMAIL PROTECTED]> wrote:
>
> +++ b/drivers/serial/mpc512x_uart.c
>
> +#include
Purely to avoid suggestions of favouritism, I will not the above. :-)
> +static struct of_device_id mpc512x_uart_of_match[] = {
Please make this const.
> +static void
On 1/8/08, John Rigby <[EMAIL PROTECTED]> wrote:
> Thanks for the quick feedback Grant.
>
> Grant Likely wrote:
> > Exactly *how* different is the 5121 PSC from the 5200 PSC? If it is
> > really different, then it makes sense to clone.
> The fifo handling has completely changed that is the main di
Thanks for the quick feedback Grant.
Grant Likely wrote:
> Exactly *how* different is the 5121 PSC from the 5200 PSC? If it is
> really different, then it makes sense to clone.
The fifo handling has completely changed that is the main difference.
> In fact; I'd
> duplicate the mpc52xx_psc.h fil
Exactly *how* different is the 5121 PSC from the 5200 PSC? If it is
really different, then it makes sense to clone. In fact; I'd
duplicate the mpc52xx_psc.h file also to avoid any crossover.
However, if the differences are manegable, I'd rather see a single
driver that can drive either type of P
mpc512x_uart.c is based on mpc52xx_uart.c with
names changed
arch/ppc support removed
512x psc fifo support added
shares mpc52xx_psc.h with 52xx driver
Signed-off-by: John Rigby <[EMAIL PROTECTED]>
---
drivers/serial/Kconfig| 18 +
drivers/serial/Makefile |
