Re: [PATCH 6/8] cleanup do_init_bootmem()

2008-12-15 Thread Paul Mackerras
Dave Hansen writes: > I'm debating whether this is worth it. It makes this a bit more clean > looking, but doesn't seriously enhance readability. But, I do think > it helps a bit. I get this when compiling a pseries config (with the patches up to this point applied but not 7/8 or 8/8): CC

Re: [PATCH 6/8] cleanup do_init_bootmem()

2008-12-09 Thread Serge E. Hallyn
Quoting Dave Hansen ([EMAIL PROTECTED]): > > I'm debating whether this is worth it. It makes this a bit more clean > looking, but doesn't seriously enhance readability. But, I do think > it helps a bit. > > Thoughts? Absolutely. do_init_bootmem_node() is *still* a bit largish, but far better b

[PATCH 6/8] cleanup do_init_bootmem()

2008-12-09 Thread Dave Hansen
I'm debating whether this is worth it. It makes this a bit more clean looking, but doesn't seriously enhance readability. But, I do think it helps a bit. Thoughts? Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> --- linux-2.6.git-dave/arch/powerpc/mm/numa.c | 104 +++--