Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-12 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 12/10/2009 07:46:14: > > On Mon, 2009-10-12 at 07:36 +0200, Joakim Tjernlund wrote: > > Benjamin Herrenschmidt wrote on 12/10/2009 > > 00:44:56: > > > On Mon, 2009-10-12 at 00:19 +0200, Joakim Tjernlund wrote: > > > > > > > > I hear you, I can remove DTLB error wi

Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Benjamin Herrenschmidt
On Mon, 2009-10-12 at 07:36 +0200, Joakim Tjernlund wrote: > Benjamin Herrenschmidt wrote on 12/10/2009 > 00:44:56: > > On Mon, 2009-10-12 at 00:19 +0200, Joakim Tjernlund wrote: > > > > > > I hear you, I can remove DTLB error with an add on patch later if that is > > > OK? > > > I cannot remove

Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 12/10/2009 00:44:56: > On Mon, 2009-10-12 at 00:19 +0200, Joakim Tjernlund wrote: > > > > I hear you, I can remove DTLB error with an add on patch later if that is > > OK? > > I cannot remove the DARFix though, when I move that to do_page_fault(), I > > get > > du

Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Benjamin Herrenschmidt
On Mon, 2009-10-12 at 00:19 +0200, Joakim Tjernlund wrote: > > I hear you, I can remove DTLB error with an add on patch later if that is OK? > I cannot remove the DARFix though, when I move that to do_page_fault(), I get > duplicate TLB hits on the same insn. It is like when transfer_to_handler()

Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 11/10/2009 23:25:30: > > On Sun, 2009-10-11 at 18:35 +0200, Joakim Tjernlund wrote: > > only DTLB Miss did set this bit, DTLB Error needs too otherwise > > the setting is lost when the page becomes dirty. > > Easier fix: Stop doing thing in DTLB Error > > Ben. I he

Re: [PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Benjamin Herrenschmidt
On Sun, 2009-10-11 at 18:35 +0200, Joakim Tjernlund wrote: > only DTLB Miss did set this bit, DTLB Error needs too otherwise > the setting is lost when the page becomes dirty. Easier fix: Stop doing thing in DTLB Error Ben. > -- > arch/powerpc/kernel/head_8xx.S | 13 ++--- > 1 files c

[PATCH 6/8] 8xx: Add missing Guarded setting in DTLB Error.

2009-10-11 Thread Joakim Tjernlund
only DTLB Miss did set this bit, DTLB Error needs too otherwise the setting is lost when the page becomes dirty. --- arch/powerpc/kernel/head_8xx.S | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S