* Paul Mackerras wrote:
> Ingo Molnar writes:
>
> > Note, i left out this bit from the commit - we need to find a
> > better solution than to allow ugly warnings on PowerPC.
> >
> > Could we use the kernel's u64 type directly perhaps? That would
> > allow us to change all __u64 to u64 in all
Ingo Molnar writes:
> Note, i left out this bit from the commit - we need to find a better
> solution than to allow ugly warnings on PowerPC.
>
> Could we use the kernel's u64 type directly perhaps? That would
> allow us to change all __u64 to u64 in all of tools/perf/ which is a
> nice clean-
* Paul Mackerras wrote:
> This also removes the -Werror flag when building on a 64-bit powerpc
> machine. The userspace definition of u64 is unsigned long rather
> than unsigned long long, meaning that gcc warns every time a u64
> is printed with %Lx or %llx (though that does work properly).
>
* Paul Mackerras wrote:
> Ingo Molnar writes:
>
> > ah, it does this:
> >
> > /*
> > * This is here because we used to use l64 for 64bit powerpc
> > * and we don't want to impact user mode with our change to ll64
> > * in the kernel.
> > */
> > #if defined(__powerpc64__) && !defined(__KERN
Ingo Molnar writes:
> ah, it does this:
>
> /*
> * This is here because we used to use l64 for 64bit powerpc
> * and we don't want to impact user mode with our change to ll64
> * in the kernel.
> */
> #if defined(__powerpc64__) && !defined(__KERNEL__)
> # include
> #else
> # include
> #endi
* Paul Mackerras wrote:
> +++ b/tools/perf/Makefile
> @@ -157,9 +157,21 @@ uname_R := $(shell sh -c 'uname -r 2>/dev/null || echo
> not')
> uname_P := $(shell sh -c 'uname -p 2>/dev/null || echo not')
> uname_V := $(shell sh -c 'uname -v 2>/dev/null || echo not')
>
> +# If we're on a 64-bit
On 64-bit powerpc, perf needs to be built as a 64-bit executable.
This arranges to add the -m64 flag to CFLAGS if we are running on
a 64-bit machine, indicated by the result of uname -m ending in "64".
This means that we'll use -m64 on x86_64 machines as well.
This also removes the -Werror flag wh
