Re: [PATCH 59/60] microblaze_v4: syscall_table.S and unistd.h

2008-06-27 Thread Paul Mundt
On Thu, Jun 26, 2008 at 02:30:28PM +0200, [EMAIL PROTECTED] wrote: > +#define __NR_semtimedop 325 > +#define __NR_timerfd_settime 326 > +#define __NR_timerfd_gettime 327 > + > +#ifdef __KERNEL__ > + > +#define __NR_syscalls327 > + Off-by-1 on __NR_syscalls, this should

Re: [PATCH 59/60] microblaze_v4: syscall_table.S and unistd.h

2008-06-26 Thread H. Peter Anvin
Arnd Bergmann wrote: You still set __NR_fork. There is no point defining the number if you can't actually call the syscall in the first place. Worse, it is actively *harmful* to set the number; klibc or anything that uses similar kinds of scripts for portability will see the symbol and thin

Re: [PATCH 59/60] microblaze_v4: syscall_table.S and unistd.h

2008-06-26 Thread Arnd Bergmann
On Thursday 26 June 2008, [EMAIL PROTECTED] wrote: > From: Michal Simek <[EMAIL PROTECTED]> > > > Signed-off-by: Michal Simek <[EMAIL PROTECTED]> > --- > arch/microblaze/kernel/syscall_table.S | 330 +++ > include/asm-microblaze/unistd.h| 390 >

[PATCH 59/60] microblaze_v4: syscall_table.S and unistd.h

2008-06-26 Thread monstr
From: Michal Simek <[EMAIL PROTECTED]> Signed-off-by: Michal Simek <[EMAIL PROTECTED]> --- arch/microblaze/kernel/syscall_table.S | 330 +++ include/asm-microblaze/unistd.h| 390 2 files changed, 720 insertions(+), 0 deletions(-)