Re: [bg-linux] [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Kazutomo Yoshii
On 05/19/2011 09:13 PM, Benjamin Herrenschmidt wrote: On Fri, 2011-05-20 at 12:08 +1000, Benjamin Herrenschmidt wrote: On Thu, 2011-05-19 at 20:32 -0500, Kazutomo Yoshii wrote: Actually DMA sends invalidate requests to the snoop unit(L2 level). BGP SoC is a bit different from other 4x

Re: [bg-linux] [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Benjamin Herrenschmidt
On Thu, 2011-05-19 at 22:02 -0500, Kazutomo Yoshii wrote: > On 05/19/2011 09:13 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2011-05-20 at 12:08 +1000, Benjamin Herrenschmidt wrote: > > > >> On Thu, 2011-05-19 at 20:32 -0500, Kazutomo Yoshii wrote: > >> > >>> Actually DMA sends invalidat

Re: [bg-linux] [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Benjamin Herrenschmidt
On Fri, 2011-05-20 at 12:08 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2011-05-19 at 20:32 -0500, Kazutomo Yoshii wrote: > > > > Actually DMA sends invalidate requests to the snoop unit(L2 level). > > BGP SoC is a bit different from other 4xx base. > > Well, some other 44x also have a snoopi

Re: [bg-linux] [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Benjamin Herrenschmidt
On Thu, 2011-05-19 at 20:32 -0500, Kazutomo Yoshii wrote: > > Actually DMA sends invalidate requests to the snoop unit(L2 level). > BGP SoC is a bit different from other 4xx base. Well, some other 44x also have a snooping L2 (more or less), but L1 is usually the problem. Cheers, Ben.

Re: [bg-linux] [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Kazutomo Yoshii
On 05/19/2011 07:36 PM, Benjamin Herrenschmidt wrote: On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: For BGP, it is convenient for 'kmalloc' to come back with 32-byte aligned units for torus DMA Signed-off-by: Eric Van Hensbergen --- arch/powerpc/include/asm/page_32.h |

Re: [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Benjamin Herrenschmidt
On Thu, 2011-05-19 at 19:47 -0500, Eric Van Hensbergen wrote: > On Thu, May 19, 2011 at 7:36 PM, Benjamin Herrenschmidt > wrote: > > On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: > >> > >> -#ifdef CONFIG_NOT_COHERENT_CACHE > >> +#if defined(CONFIG_NOT_COHERENT_CACHE) || defined(CON

Re: [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Eric Van Hensbergen
On Thu, May 19, 2011 at 7:36 PM, Benjamin Herrenschmidt wrote: > On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: >> >> -#ifdef CONFIG_NOT_COHERENT_CACHE >> +#if defined(CONFIG_NOT_COHERENT_CACHE) || defined(CONFIG_BGP) >>  #define ARCH_DMA_MINALIGN    L1_CACHE_BYTES >>  #endif > > Is

Re: [PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-19 Thread Benjamin Herrenschmidt
On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote: > For BGP, it is convenient for 'kmalloc' to come back with 32-byte > aligned units for torus DMA > > Signed-off-by: Eric Van Hensbergen > --- > arch/powerpc/include/asm/page_32.h |2 +- > 1 files changed, 1 insertions(+), 1 delet

[PATCH 5/7] [RFC] force 32-byte aligned kmallocs

2011-05-18 Thread Eric Van Hensbergen
For BGP, it is convenient for 'kmalloc' to come back with 32-byte aligned units for torus DMA Signed-off-by: Eric Van Hensbergen --- arch/powerpc/include/asm/page_32.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/include/asm/page_32.h b/arch/powerpc/inc