Re: [PATCH 5/6] tty: Add SBI debug console support to HVC SBI driver

2023-10-10 Thread Anup Patel
On Tue, Oct 10, 2023 at 10:42 PM Greg Kroah-Hartman wrote: > > On Tue, Oct 10, 2023 at 10:35:02PM +0530, Anup Patel wrote: > > --- a/drivers/tty/hvc/hvc_riscv_sbi.c > > +++ b/drivers/tty/hvc/hvc_riscv_sbi.c > > @@ -15,6 +15,7 @@ > > > > #include "hvc_console.h" > > > > +#ifdef CONFIG_RISCV_SBI_V0

Re: [PATCH 5/6] tty: Add SBI debug console support to HVC SBI driver

2023-10-10 Thread Greg Kroah-Hartman
On Tue, Oct 10, 2023 at 10:35:02PM +0530, Anup Patel wrote: > --- a/drivers/tty/hvc/hvc_riscv_sbi.c > +++ b/drivers/tty/hvc/hvc_riscv_sbi.c > @@ -15,6 +15,7 @@ > > #include "hvc_console.h" > > +#ifdef CONFIG_RISCV_SBI_V01 Please no #ifdef in a .c file, that's not a good style for Linux code a

[PATCH 5/6] tty: Add SBI debug console support to HVC SBI driver

2023-10-10 Thread Anup Patel
From: Atish Patra RISC-V SBI specification supports advanced debug console support via SBI DBCN extension. Extend the HVC SBI driver to support it. Signed-off-by: Atish Patra Signed-off-by: Anup Patel --- drivers/tty/hvc/Kconfig | 2 +- drivers/tty/hvc/hvc_riscv_sbi.c | 80 +