Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-18 Thread Andrew Donnellan
On Fri, 2025-03-14 at 15:00 +0530, Shrikanth Hegde wrote: > > Hi. Andrew, > > After this change below dev_dbg will be called with mutex held still. > Is > that a concern? I don't see the mutex being used in that path. > > Since using scoped_guard cause more code churn here, I would prefer > not

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-14 Thread Shrikanth Hegde
On 3/14/25 15:00, Shrikanth Hegde wrote: On 3/14/25 11:15, Shrikanth Hegde wrote: use guard(mutex) for scope based resource management of mutex. This would make the code simpler and easier to maintain. More details on lock guards can be found at https://lore.kernel.org/all/20230612093537.6

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-14 Thread Andrew Donnellan
On Fri, 2025-03-14 at 11:15 +0530, Shrikanth Hegde wrote: > use guard(mutex) for scope based resource management of mutex. > This would make the code simpler and easier to maintain. > > More details on lock guards can be found at > https://lore.kernel.org/all/20230612093537.614161...@infradead.org

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-14 Thread Shrikanth Hegde
On 3/14/25 11:15, Shrikanth Hegde wrote: use guard(mutex) for scope based resource management of mutex. This would make the code simpler and easier to maintain. More details on lock guards can be found at https://lore.kernel.org/all/20230612093537.614161...@infradead.org/T/#u Signed-off-by:

Re: [PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-13 Thread Shrikanth Hegde
On 3/14/25 11:36, Andrew Donnellan wrote: On Fri, 2025-03-14 at 11:15 +0530, Shrikanth Hegde wrote: use guard(mutex) for scope based resource management of mutex. This would make the code simpler and easier to maintain. More details on lock guards can be found at https://lore.kernel.org/all/

[PATCH 5/6] powerpc: powenv: oxcl: use lock guard for mutex

2025-03-13 Thread Shrikanth Hegde
use guard(mutex) for scope based resource management of mutex. This would make the code simpler and easier to maintain. More details on lock guards can be found at https://lore.kernel.org/all/20230612093537.614161...@infradead.org/T/#u Signed-off-by: Shrikanth Hegde --- arch/powerpc/platforms/p