Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-07 Thread Anton Vorontsov
On Thu, Aug 07, 2008 at 05:31:44PM +0800, Li Yang wrote: [...] > > > > > reg = <0x6c0 0x40 0x8b00 0x100>; > > > interrupts = <11>; > > > interrupt-parent = <&qeic>; > > > mode = "slave"; > > > > I'd suggest to rename this to

Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-07 Thread Li Yang
Hi Anton, On Wed, 2008-08-06 at 16:07 +0400, Anton Vorontsov wrote: > Hello Li, > > On Wed, Aug 06, 2008 at 03:04:44PM +0800, Li Yang wrote: > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > > --- > > arch/powerpc/boot/dts/mpc836x_mds.dts | 15 ++- > > arch/powerpc/platforms/83xx/mpc836

Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-06 Thread Li Yang
On Wed, 2008-08-06 at 12:29 -0500, Scott Wood wrote: > On Wed, Aug 06, 2008 at 03:04:44PM +0800, Li Yang wrote: > > [EMAIL PROTECTED] { > > - compatible = "qe_udc"; > > + compatible = "fsl,qe_udc"; > [snip] > > + > > + np = of_find_compatibl

Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-06 Thread Scott Wood
On Wed, Aug 06, 2008 at 03:04:44PM +0800, Li Yang wrote: > [EMAIL PROTECTED] { > - compatible = "qe_udc"; > + compatible = "fsl,qe_udc"; [snip] > + > + np = of_find_compatible_node(NULL, NULL, "fsl,qe_udc"); > + if (np) {

Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-06 Thread Anton Vorontsov
Hello Li, On Wed, Aug 06, 2008 at 03:04:44PM +0800, Li Yang wrote: > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc836x_mds.dts | 15 ++- > arch/powerpc/platforms/83xx/mpc836x_mds.c | 19 - > arch/powerpc/platforms/83xx/mpc83xx.h |1 + > a

Re: [PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-06 Thread Stephen Rothwell
Hi Li, On Wed, 6 Aug 2008 15:04:44 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > > @@ -93,6 +93,12 @@ static void __init mpc836x_mds_setup_arch(void) > > for (np = NULL; (np = of_find_node_by_name(np, "ucc")) != NULL;) > par_io_of_config(np); > + > +

[PATCH 5/6] powerpc: add USB peripheral support to MPC836xMDS

2008-08-05 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc836x_mds.dts | 15 ++- arch/powerpc/platforms/83xx/mpc836x_mds.c | 19 - arch/powerpc/platforms/83xx/mpc83xx.h |1 + arch/powerpc/platforms/83xx/usb.c | 67 + 4