Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-04-04 Thread Nathan Chancellor
On Tue, Mar 18, 2025 at 10:13:35PM +0100, Arnd Bergmann wrote: > Thanks for the report, I missed that the generic ioport_map() function > is missing the PCI_IOBASE macro, we should probably remove that from > the asm-generic/io.h header and require architectures to define it > themselves, since the

Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-03-19 Thread Arnd Bergmann
On Wed, Mar 19, 2025, at 18:30, Nathan Chancellor wrote: > On Tue, Mar 18, 2025 at 10:13:35PM +0100, Arnd Bergmann wrote: >> Thanks for the report, I missed that the generic ioport_map() function >> is missing the PCI_IOBASE macro, we should probably remove that from >> the asm-generic/io.h header

Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-03-18 Thread Arnd Bergmann
On Tue, Mar 18, 2025, at 21:39, Nathan Chancellor wrote: > On Sat, Mar 15, 2025 at 11:59:06AM +0100, Arnd Bergmann wrote: >> From: Arnd Bergmann >> diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h >> void __ioread64_copy(void *to, const void __iomem *from, size_t count); >>

Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-03-18 Thread Nathan Chancellor
Hi Arnd, On Sat, Mar 15, 2025 at 11:59:06AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > All PIO on MIPS platforms is memory mapped, so there is no benefit in > the lib/iomap.c wrappers that switch between inb/outb and readb/writeb > style accessses. > > In fact, the '#define PIO_RESER

[PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-03-15 Thread Arnd Bergmann
From: Arnd Bergmann All PIO on MIPS platforms is memory mapped, so there is no benefit in the lib/iomap.c wrappers that switch between inb/outb and readb/writeb style accessses. In fact, the '#define PIO_RESERVED 0' setting completely disables the GENERIC_IOMAP functionality, and the '#define PI