Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-17 Thread Grant Likely
On Thu, Jun 17, 2010 at 5:57 PM, Benjamin Herrenschmidt wrote: > On Thu, 2010-06-17 at 17:11 -0600, Grant Likely wrote: >> On Thu, Jun 10, 2010 at 7:17 PM, Benjamin Herrenschmidt >> wrote: >> > On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: >> >> >> >> Okay.  I had been trying to avoid #i

Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-17 Thread Benjamin Herrenschmidt
On Thu, 2010-06-17 at 17:11 -0600, Grant Likely wrote: > On Thu, Jun 10, 2010 at 7:17 PM, Benjamin Herrenschmidt > wrote: > > On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: > >> > >> Okay. I had been trying to avoid #ifdefs in the common code, but > >> you're probably right. I'll rework.

Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-17 Thread Grant Likely
On Thu, Jun 10, 2010 at 7:17 PM, Benjamin Herrenschmidt wrote: > On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: >> >> Okay.  I had been trying to avoid #ifdefs in the common code, but >> you're probably right.  I'll rework. > > Not even ifdef's ... just move the quirk map there. You can al

Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-10 Thread Benjamin Herrenschmidt
On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote: > > Okay. I had been trying to avoid #ifdefs in the common code, but > you're probably right. I'll rework. Not even ifdef's ... just move the quirk map there. You can always #define the quirk variable to 0 on archs that have no quirks, to

Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-10 Thread Grant Likely
On Thu, Jun 10, 2010 at 12:40 AM, Benjamin Herrenschmidt wrote: > On Fri, 2010-06-04 at 15:21 -0600, Grant Likely wrote: >> Merge common implementation of of_irq_map_one().  Rename it to >> __of_irq_map_one() so that arch code can either use the stock >> implementation, or override it to handle pl

Re: [PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-09 Thread Benjamin Herrenschmidt
On Fri, 2010-06-04 at 15:21 -0600, Grant Likely wrote: > Merge common implementation of of_irq_map_one(). Rename it to > __of_irq_map_one() so that arch code can either use the stock > implementation, or override it to handle platform quirks. Similar comment to before, I think the breakup of func

[PATCH 5/5] of/irq: merge of_irq_map_one()

2010-06-04 Thread Grant Likely
Merge common implementation of of_irq_map_one(). Rename it to __of_irq_map_one() so that arch code can either use the stock implementation, or override it to handle platform quirks. Signed-off-by: Grant Likely CC: Michal Simek CC: Wolfram Sang CC: Stephen Rothwell CC: Benjamin Herrenschmidt