Re: [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure

2009-03-18 Thread Grant Likely
On Tue, Mar 10, 2009 at 2:29 PM, Anton Vorontsov wrote: > On Tue, Mar 10, 2009 at 01:48:26PM -0600, Grant Likely wrote: >> Regardless, I >> think all the drivers should be using common code for obtaining the >> phy_device from the device tree. > > Not necessary `struct phy_device'. All we need is

Re: [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure

2009-03-10 Thread Anton Vorontsov
On Tue, Mar 10, 2009 at 01:48:26PM -0600, Grant Likely wrote: [...] > >> eliminates the assumption that the PHY for the FEC is always > >> attached to the FEC's own MDIO bus. With this patch, the FEC can > >> use a PHY attached to any MDIO bus if it is described in the device > >> tree. > > > > AFA

Re: [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure

2009-03-10 Thread Grant Likely
On Tue, Mar 10, 2009 at 1:16 PM, Anton Vorontsov wrote: > On Tue, Mar 10, 2009 at 09:22:24AM -0600, Grant Likely wrote: >> From: Grant Likely > [...] >> +static int mpc52xx_fec_notifier_phy_add(struct notifier_block *nb, >> +                                     unsigned long event, void *_dev) >>

Re: [PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure

2009-03-10 Thread Anton Vorontsov
On Tue, Mar 10, 2009 at 09:22:24AM -0600, Grant Likely wrote: > From: Grant Likely [...] > +static int mpc52xx_fec_notifier_phy_add(struct notifier_block *nb, > + unsigned long event, void *_dev) > +{ [...] > + rc = phy_connect_direct(priv->ndev, priv->phyde

[PATCH 5/5] net: make mpc5200 fec driver use of_mdio infrastructure

2009-03-10 Thread Grant Likely
From: Grant Likely The patch reworks the MPC5200 Fast Ethernet Controller (FEC) driver to use the of_mdio infrastructure for registering PHY devices from data out openfirmware device tree, and eliminates the assumption that the PHY for the FEC is always attached to the FEC's own MDIO bus. With t