Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

2007-09-13 Thread Dan Williams
On 9/13/07, Zhang Wei-r63237 <[EMAIL PROTECTED]> wrote: > Hi, > > > > +static void fsl_dma_set_src(dma_addr_t addr, > > > + struct dma_async_tx_descriptor > > *tx, int index) > > > +{ > > > > What is index supposed to mean? It's not used, or documented > > anywhere than >

Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

2007-09-13 Thread Scott Wood
On Thu, Sep 13, 2007 at 03:13:06AM -0700, Zhang Wei-r63237 wrote: > > After dropping the lock, you can no longer assume that your > > iterator is > > still valid; you need to work off of the list head. > > > > list_for_each_entry_safe() is used here. I think the safe should be ok. > :P Nope. T

RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors.

2007-09-13 Thread Zhang Wei-r63237
Hi, > > +static void fsl_dma_set_src(dma_addr_t addr, > > + struct dma_async_tx_descriptor > *tx, int index) > > +{ > > What is index supposed to mean? It's not used, or documented > anywhere than > I can see. I've also got more document here. Hi, Dan, could you giv