Re: [PATCH 4/8] char/rtc: move mc146818rtc code out of asm-generic/rtc.h

2016-04-27 Thread Arnd Bergmann
On Wednesday 27 April 2016 11:29:12 Alexandre Belloni wrote: > The subject should be: > rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h Good point, the functions are only used by rtc-cmos, not the old drivers/char/rtc.c. > Else, you can add: > Acked-by: Alexandre Belloni Thanks.

Re: [PATCH 4/8] char/rtc: move mc146818rtc code out of asm-generic/rtc.h

2016-04-27 Thread Alexandre Belloni
The subject should be: rtc: cmos: move mc146818rtc code out of asm-generic/rtc.h Else, you can add: Acked-by: Alexandre Belloni On 26/04/2016 at 23:44:08 +0200, Arnd Bergmann wrote : > Drivers should not really include stuff from asm-generic directly, > and the PC-style cmos rtc driver does thi

[PATCH 4/8] char/rtc: move mc146818rtc code out of asm-generic/rtc.h

2016-04-26 Thread Arnd Bergmann
Drivers should not really include stuff from asm-generic directly, and the PC-style cmos rtc driver does this in order to reuse the mc146818 implementation of get_rtc_time/set_rtc_time rather than the architecture specific one for the architecture it gets built for. To make it more obvious what is