Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread David Brownell
On Monday 21 April 2008, Anton Vorontsov wrote: > On Mon, Apr 21, 2008 at 01:01:12PM -0700, David Brownell wrote: > > The way other platforms do this is to hav SOC-specific > > init code, and have board-specific initcalls call the > > relevant SOC-specific setup. > > I don't know about other plat

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Anton Vorontsov
On Mon, Apr 21, 2008 at 01:01:12PM -0700, David Brownell wrote: > On Monday 21 April 2008, Anton Vorontsov wrote: > >  From: J. Random Hacker > >  Subject: [POWERPC] cleanup board initialization code > > > >  This patch removes vast amount of machine_arch_initcall()s that were > >  used to solely

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Grant Likely
On Mon, Apr 21, 2008 at 10:41 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Mon, Apr 21, 2008 at 08:58:09AM -0600, Grant Likely wrote: > > Its not great. It has a boot time impact for every platform compiled > > into the kernel. The problem gets worse every time another block of > > code

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread David Brownell
On Monday 21 April 2008, Anton Vorontsov wrote: >  From: J. Random Hacker >  Subject: [POWERPC] cleanup board initialization code > >  This patch removes vast amount of machine_arch_initcall()s that were >  used to solely initialize some hardware, like this: > >  qe_add_gpio_chips(); >  fsl_gtm_i

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Anton Vorontsov
On Mon, Apr 21, 2008 at 08:58:09AM -0600, Grant Likely wrote: > On Mon, Apr 21, 2008 at 8:49 AM, Anton Vorontsov > <[EMAIL PROTECTED]> wrote: > > > > Should this really be a arch_initcall()? Would it be better for > > > > platforms needing it to call it explicitly from one of the platform's > >

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Segher Boessenkool
Also, why is encoded in compatible? Do the different banks have different register interfaces? Yes, they could. For example, interrupt pins are bank-specific. In what way? If different banks just have different IRQ #s, there are easier ways to express this. Segher ___

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Grant Likely
On Mon, Apr 21, 2008 at 8:49 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > Should this really be a arch_initcall()? Would it be better for > > > platforms needing it to call it explicitly from one of the platform's > > > machine_arch_initcall()? Otherwise it gets called for all platform

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Anton Vorontsov
On Mon, Apr 21, 2008 at 06:33:13PM +0400, Anton Vorontsov wrote: [...] > > > +static int __init qe_add_gpiochips(void) > > > +{ > > > + int ret; > > > + struct device_node *np; > > > + > > > + for_each_compatible_node(np, NULL, "fsl,qe-pario-bank") { > > > + s

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Anton Vorontsov
On Mon, Apr 21, 2008 at 08:19:05AM -0600, Grant Likely wrote: > On Fri, Apr 18, 2008 at 1:09 PM, Anton Vorontsov > <[EMAIL PROTECTED]> wrote: > > This is needed to access QE GPIOs via Linux GPIO API. > > > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > --- > > diff --git a/Documentatio

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-21 Thread Grant Likely
On Fri, Apr 18, 2008 at 1:09 PM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > This is needed to access QE GPIOs via Linux GPIO API. > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > --- > diff --git a/Documentation/powerpc/booting-without-of.txt > b/Documentation/powerpc/booting-without-

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-18 Thread David Brownell
On Friday 18 April 2008, Anton Vorontsov wrote: > On Thu, Apr 17, 2008 at 09:21:40PM -0500, Kumar Gala wrote: > > On Apr 17, 2008, at 5:41 PM, Anton Vorontsov wrote: > >> > >> No problem. Would you prefer this to go under drivers/gpio/ ? > > > > Yes that would be better.  We actively worked on pul

[PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-18 Thread Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- On Thu, Apr 17, 2008 at 09:21:40PM -0500, Kumar Gala wrote: > > On Apr 17, 2008, at 5:41 PM, Anton Vorontsov wrote: >> On Thu, Apr 17, 2008 at 05:35:53PM -0500, Kumar Gala wrote: inde

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Kumar Gala
On Apr 17, 2008, at 5:41 PM, Anton Vorontsov wrote: On Thu, Apr 17, 2008 at 05:35:53PM -0500, Kumar Gala wrote: index a3f9c3f..a4a195a 100644 --- a/arch/powerpc/sysdev/qe_lib/qe_io.c +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c @@ -20,7 +20,8 @@ #include #include #include - +#include +#include

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Anton Vorontsov
On Thu, Apr 17, 2008 at 05:35:53PM -0500, Kumar Gala wrote: >> index a3f9c3f..a4a195a 100644 >> --- a/arch/powerpc/sysdev/qe_lib/qe_io.c >> +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c >> @@ -20,7 +20,8 @@ >> #include >> #include >> #include >> - >> +#include >> +#include >> #include >> #include

Re: [PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Kumar Gala
index a3f9c3f..a4a195a 100644 --- a/arch/powerpc/sysdev/qe_lib/qe_io.c +++ b/arch/powerpc/sysdev/qe_lib/qe_io.c @@ -20,7 +20,8 @@ #include #include #include - +#include +#include #include #include #include @@ -214,6 +215,140 @@ int par_io_of_config(struct device_node *np) } EXPORT_SYMBOL(p

[PATCH 4/5] [POWERPC] QE: implement support for the GPIO LIB API

2008-04-17 Thread Anton Vorontsov
This is needed to access QE GPIOs via Linux GPIO API. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 34 --- arch/powerpc/platforms/Kconfig |2 + arch/powerpc/sysdev/qe_lib/qe_io.c | 137