Re: [PATCH 4/4] powerpc/perf: Use perf_instruction_pointer in callchains

2012-06-27 Thread Scott Wood
On 06/26/2012 10:59 PM, Anton Blanchard wrote: > > Hi Scott, > >> Won't this break core-fsl-emb, which doesn't define >> perf_instruction_pointer()? > > It links ok for me. You should get the default version: > > #ifndef perf_misc_flags > # define perf_misc_flags(regs) \ > (user

Re: [PATCH 4/4] powerpc/perf: Use perf_instruction_pointer in callchains

2012-06-26 Thread Anton Blanchard
Hi Scott, > Won't this break core-fsl-emb, which doesn't define > perf_instruction_pointer()? It links ok for me. You should get the default version: #ifndef perf_misc_flags # define perf_misc_flags(regs) \ (user_mode(regs) ? PERF_RECORD_MISC_USER : PERF_RECORD_MISC_KERNEL) # d

Re: [PATCH 4/4] powerpc/perf: Use perf_instruction_pointer in callchains

2012-06-26 Thread Scott Wood
On 06/26/2012 06:04 AM, Anton Blanchard wrote: > > We use SIAR or regs->nip for the instruction pointer depending on > the PMU configuration, but we always use regs->nip in the callchain. > > Use perf_instruction_pointer so the backtrace is consistent. > > Signed-off-by: Anton Blanchard > --- >

[PATCH 4/4] powerpc/perf: Use perf_instruction_pointer in callchains

2012-06-26 Thread Anton Blanchard
We use SIAR or regs->nip for the instruction pointer depending on the PMU configuration, but we always use regs->nip in the callchain. Use perf_instruction_pointer so the backtrace is consistent. Signed-off-by: Anton Blanchard --- Index: linux-build/arch/powerpc/perf/callchain.c ==