Re: [PATCH 4/4] perf/powerpc: Implement group_read() txn interface for 24x7 counters

2015-04-01 Thread Peter Zijlstra
On Wed, Mar 25, 2015 at 10:57:05PM -0700, Sukadev Bhattiprolu wrote: > Would something liks this work? > Sure, that looks fine. Thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 4/4] perf/powerpc: Implement group_read() txn interface for 24x7 counters

2015-03-25 Thread Sukadev Bhattiprolu
Peter Zijlstra [pet...@infradead.org] wrote: | | Is there a down-side to always doing the txn based group read? If an | arch does not implement the read txn support it'll fall back to doing | independent read ops, but we end up doing those anyway. | | That way we get less special case code. We c

Re: [PATCH 4/4] perf/powerpc: Implement group_read() txn interface for 24x7 counters

2015-03-16 Thread Peter Zijlstra
On Wed, Mar 04, 2015 at 12:35:08AM -0800, Sukadev Bhattiprolu wrote: > +++ b/kernel/events/core.c > @@ -3677,11 +3677,34 @@ u64 perf_event_read_value(struct perf_event *event, > u64 *enabled, u64 *running, > } > EXPORT_SYMBOL_GPL(perf_event_read_value); > > +static int do_pmu_group_read(struct

[PATCH 4/4] perf/powerpc: Implement group_read() txn interface for 24x7 counters

2015-03-04 Thread Sukadev Bhattiprolu
The 24x7 counters in Powerpc allow monitoring a large number of counters simultaneously. They also allow reading several counters in a single HCALL so we can get a more consistent snapshot of the system. Use the PMU's transaction interface to monitor and read several event counters at once. The id