Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-22 Thread Scott Wood
On Fri, Aug 22, 2008 at 09:56:16AM -0400, Jimi Xenidis wrote: > Sorry, I have not really been following this, I assume you are > replacing SPR accesses with load/stores that do not trap. > I believe thats fine for reading any SPR, but not true for modifying > some SPRs, particularly MSR. > IMHO

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-22 Thread Jimi Xenidis
On Aug 22, 2008, at 4:17 AM, Kumar Gala wrote: On Aug 22, 2008, at 3:08 AM, Christian Ehrhardt wrote: Scott Wood wrote: On Thu, Aug 21, 2008 at 09:21:39AM -0500, Kumar Gala wrote: Where is the other discussion? I'd like to understand what's going on here.. (especially since I added the

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-22 Thread Kumar Gala
On Aug 22, 2008, at 3:08 AM, Christian Ehrhardt wrote: Scott Wood wrote: On Thu, Aug 21, 2008 at 09:21:39AM -0500, Kumar Gala wrote: Where is the other discussion? I'd like to understand what's going on here.. (especially since I added the wrtee[i] changes to kernel way back when).

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-22 Thread Christian Ehrhardt
Scott Wood wrote: On Thu, Aug 21, 2008 at 09:21:39AM -0500, Kumar Gala wrote: Where is the other discussion? I'd like to understand what's going on here.. (especially since I added the wrtee[i] changes to kernel way back when). Presumably, they want to be able to replace wrtee with

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-21 Thread Scott Wood
On Thu, Aug 21, 2008 at 09:21:39AM -0500, Kumar Gala wrote: > Where is the other discussion? I'd like to understand what's going on > here.. (especially since I added the wrtee[i] changes to kernel way > back when). Presumably, they want to be able to replace wrtee with a store to a hyperviso

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-21 Thread Kumar Gala
On Aug 21, 2008, at 9:13 AM, Christian Ehrhardt wrote: Kumar Gala wrote: On Aug 19, 2008, at 5:36 AM, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hyp

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-21 Thread Christian Ehrhardt
Kumar Gala wrote: On Aug 19, 2008, at 5:36 AM, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hypervisor to rewrite those to nontrapping instructions. Mayb

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-21 Thread Kumar Gala
On Aug 19, 2008, at 5:36 AM, [EMAIL PROTECTED] wrote: From: Christian Ehrhardt <[EMAIL PROTECTED]> Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hypervisor to rewrite those to nontrapping instructions. Maybe we should split

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-21 Thread Christian Ehrhardt
Josh Boyer wrote: On Wed, 20 Aug 2008 14:06:51 -0500 Hollis Blanchard <[EMAIL PROTECTED]> wrote: To be honest I unfortunately don't know how big the impact for non-virtualized systems is. I would like to test it, but without hardware performance counters on the core I have I'm not sure (ye

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-20 Thread Josh Boyer
On Wed, 20 Aug 2008 14:06:51 -0500 Hollis Blanchard <[EMAIL PROTECTED]> wrote: > > > > To be honest I unfortunately don't know how big the impact for > > > > non-virtualized systems is. I would like to test it, but without > > > > hardware performance counters on the core I have I'm not sure (y

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-20 Thread Hollis Blanchard
On Wed, 2008-08-20 at 14:52 -0400, Josh Boyer wrote: > On Wed, 2008-08-20 at 13:30 -0500, Hollis Blanchard wrote: > > On Wed, 2008-08-20 at 14:53 +0200, Christian Ehrhardt wrote: > > > > > > Arnd Bergmann wrote: > > > > On Tuesday 19 August 2008, [EMAIL PROTECTED] wrote: > > > > > > > >> Depend

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-20 Thread Josh Boyer
On Wed, 2008-08-20 at 13:30 -0500, Hollis Blanchard wrote: > On Wed, 2008-08-20 at 14:53 +0200, Christian Ehrhardt wrote: > > > > Arnd Bergmann wrote: > > > On Tuesday 19 August 2008, [EMAIL PROTECTED] wrote: > > > > > >> Dependent on the already existing CONFIG_KVM_GUEST config option > > this

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-20 Thread Hollis Blanchard
On Wed, 2008-08-20 at 14:53 +0200, Christian Ehrhardt wrote: > > Arnd Bergmann wrote: > > On Tuesday 19 August 2008, [EMAIL PROTECTED] wrote: > > > >> Dependent on the already existing CONFIG_KVM_GUEST config option > this patch > >> changes wrteei to wrtee allowing the hypervisor to rewrite th

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-20 Thread Christian Ehrhardt
Arnd Bergmann wrote: On Tuesday 19 August 2008, [EMAIL PROTECTED] wrote: Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hypervisor to rewrite those to nontrapping instructions. Maybe we should split the kvm guest otpimizations

Re: [PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-19 Thread Arnd Bergmann
On Tuesday 19 August 2008, [EMAIL PROTECTED] wrote: > Dependent on the already existing CONFIG_KVM_GUEST config option this patch > changes wrteei to wrtee allowing the hypervisor to rewrite those to > nontrapping > instructions. Maybe we should split the kvm guest otpimizations in two parts > one

[PATCH 4/4] kvmppc: convert wrteei to wrtee as kvm guest optimization

2008-08-19 Thread ehrhardt
From: Christian Ehrhardt <[EMAIL PROTECTED]> Dependent on the already existing CONFIG_KVM_GUEST config option this patch changes wrteei to wrtee allowing the hypervisor to rewrite those to nontrapping instructions. Maybe we should split the kvm guest otpimizations in two parts one for the overhead