Re: [PATCH 4/4] 82xx: MGCOGE support

2008-01-29 Thread Scott Wood
On Tue, Jan 29, 2008 at 01:24:54PM -0600, Scott Wood wrote: > On Tue, Jan 29, 2008 at 11:22:55AM +0100, Heiko Schocher wrote: > > + *pram_base = res.start; > > First of all, use out_be32() rather than direct dereferencing. Err, I meant out_be16() of course. :-P -Scott _

Re: [PATCH 4/4] 82xx: MGCOGE support

2008-01-29 Thread Scott Wood
On Tue, Jan 29, 2008 at 11:22:55AM +0100, Heiko Schocher wrote: > To get the serial console on the SMC2 working, the > following patch is needed: > > Fixing serial console on a SMC on MPC82xx based > board and using CONFIG_PPC_CPM_NEW_BINDING No, what's needed is for the device tree to be correct

[PATCH 4/4] 82xx: MGCOGE support

2008-01-29 Thread Heiko Schocher
Hello, To get the serial console on the SMC2 working, the following patch is needed: Fixing serial console on a SMC on MPC82xx based board and using CONFIG_PPC_CPM_NEW_BINDING Signed-off-by: Heiko Schocher <[EMAIL PROTECTED]> --- drivers/serial/cpm_uart/cpm_uart_core.c | 15 +++ 1