Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 27.04.19 15:03, John Paul Adrian Glaubitz wrote: > On 4/27/19 2:52 PM, Enrico Weigelt, metux IT consult wrote: >> Simpily io resource size computation by setting mapsize field. > > Here's a typo thx. fixed. --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-29 Thread Andy Shevchenko
On Mon, Apr 29, 2019 at 08:48:53AM +0200, Enrico Weigelt, metux IT consult wrote: > On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE 0x100 > > > > And why this is in the header file and not in corresponding C one? > > hmm, no particular reason, maybe just an old

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-29 Thread Enrico Weigelt, metux IT consult
On 28.04.19 17:21, Andy Shevchenko wrote: > >> +#define SERIAL_RT2880_IOSIZE0x100 > > And why this is in the header file and not in corresponding C one? hmm, no particular reason, maybe just an old habit to put definitions into .h files ;-) I can move it to 8250_of.c if you like me to.

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-28 Thread Andy Shevchenko
On Sat, Apr 27, 2019 at 02:52:18PM +0200, Enrico Weigelt, metux IT consult wrote: > Simpily io resource size computation by setting mapsize field. > > Some of the special cases handled by serial8250_port_size() can be > simplified by putting this data to corresponding platform data > or probe fun

Re: [PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-27 Thread John Paul Adrian Glaubitz
On 4/27/19 2:52 PM, Enrico Weigelt, metux IT consult wrote: > Simpily io resource size computation by setting mapsize field. Here's a typo Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-be

[PATCH 37/41] drivers: tty: serial: 8250: simplify io resource size computation

2019-04-27 Thread Enrico Weigelt, metux IT consult
Simpily io resource size computation by setting mapsize field. Some of the special cases handled by serial8250_port_size() can be simplified by putting this data to corresponding platform data or probe function. Signed-off-by: Enrico Weigelt --- arch/mips/alchemy/common/platform.c | 1 + driver