Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-31 Thread Breno Leitao
Hi Christophe, On 10/24/18 12:12 PM, LEROY Christophe wrote: > Breno Leitao a écrit : > >> hi Christophe, >> >> On 10/23/2018 12:38 PM, LEROY Christophe wrote: >>> Breno Leitao a écrit : This patch removes the keyword from the definition part, while keeps it in the declarati

Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-24 Thread LEROY Christophe
Breno Leitao a écrit : hi Christophe, On 10/23/2018 12:38 PM, LEROY Christophe wrote: Breno Leitao a écrit : This patch removes the keyword from the definition part, while keeps it in the declaration part. I think checkpatch also says that extern should be avoided in declarations. Than

Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-24 Thread Breno Leitao
hi Christophe, On 10/23/2018 12:38 PM, LEROY Christophe wrote: > Breno Leitao a écrit : >> >> This patch removes the keyword from the definition part, while keeps >> it in >> the declaration part. > > I think checkpatch also says that extern should be avoided in declarations. Thanks for the rev

Re: [PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-23 Thread LEROY Christophe
Breno Leitao a écrit : Function huge_ptep_set_access_flags() has the 'extern' keyword in the function definition and also in the function declaration. This causes a warning in 'sparse' since the 'extern' storage class should be used only on symbol declarations. arch/powerpc/mm/pgtable.c:232:1

[PATCH 3/9] powerpc/mm: Remove extern from function definition

2018-10-22 Thread Breno Leitao
Function huge_ptep_set_access_flags() has the 'extern' keyword in the function definition and also in the function declaration. This causes a warning in 'sparse' since the 'extern' storage class should be used only on symbol declarations. arch/powerpc/mm/pgtable.c:232:12: warning: function