Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-05-01 Thread Anatolij Gustschin
On Fri, 30 Apr 2010 15:40:12 -0500 Scott Wood wrote: > Timur Tabi wrote: > > On Fri, Apr 30, 2010 at 11:22 AM, Scott Wood > > wrote: > > > >>> That's what I meant. Actually, I think it's ULL. Regardless, I think > >>> the compiler will see the "10 ... * 1000" and just combine > >>>

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Scott Wood
Timur Tabi wrote: On Fri, Apr 30, 2010 at 11:22 AM, Scott Wood wrote: That's what I meant. Actually, I think it's ULL. Regardless, I think the compiler will see the "10 ... * 1000" and just combine them together. You're not actually outsmarting the compiler. The compiler will do n

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
On Fri, Apr 30, 2010 at 12:00 PM, Anatolij Gustschin wrote: > Thanks. Sorry for my wrong answer above, now I remember the logic > behind this and will try to explain. Actually the reason I do not > use kmalloc() here is that I do not want to _copy_ bitmap data to > newly allocated frame buffer ar

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
On Fri, Apr 30, 2010 at 11:22 AM, Scott Wood wrote: >> That's what I meant.  Actually, I think it's ULL.  Regardless, I think >> the compiler will see the  "10 ... * 1000" and just combine >> them together.  You're not actually outsmarting the compiler. > > The compiler will do no such th

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Anatolij Gustschin
On Fri, 30 Apr 2010 10:08:45 -0500 Timur Tabi wrote: > On Fri, Apr 30, 2010 at 5:19 AM, Anatolij Gustschin wrote: > > >> How about just doing this? > >> > >> .init_early             = mpc512x_init_diu, > > > > I thought it should be prepared for adding other code here. > > mpc5121_ads_init_earl

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Scott Wood
On Fri, Apr 30, 2010 at 10:08:45AM -0500, Timur Tabi wrote: > On Fri, Apr 30, 2010 at 5:19 AM, Anatolij Gustschin wrote: > > >> How about just doing this? > >> > >> .init_early             = mpc512x_init_diu, > > > > I thought it should be prepared for adding other code here. > > mpc5121_ads_init

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Timur Tabi
On Fri, Apr 30, 2010 at 5:19 AM, Anatolij Gustschin wrote: >> How about just doing this? >> >> .init_early             = mpc512x_init_diu, > > I thought it should be prepared for adding other code here. > mpc5121_ads_init_early() is generic and could contain other > things as well. I would vote f

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-30 Thread Anatolij Gustschin
On Thu, 29 Apr 2010 21:05:26 -0500 Timur Tabi wrote: > On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin wrote: > > > > +void __init mpc5121_ads_init_early(void) > > +{ > > +       mpc512x_init_diu(); > > +} > > + > >  define_machine(mpc5121_ads) { > >        .name                   = "MPC51

Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-29 Thread Timur Tabi
On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin wrote: > +void __init mpc5121_ads_init_early(void) > +{ > +       mpc512x_init_diu(); > +} > + >  define_machine(mpc5121_ads) { >        .name                   = "MPC5121 ADS", >        .probe                  = mpc5121_ads_probe, >        .se

[PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support

2010-04-29 Thread Anatolij Gustschin
MPC5121 DIU configuration/setup as initialized by the boot loader currently will get lost while booting Linux. As a result displaying the boot splash is not possible through the boot process. To prevent this we reserve configured DIU frame buffer address range while booting and preserve AOI descri