Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-23 Thread Timur Tabi
Jerry Van Baren wrote: > The "force" parameter was added to sort of emulate the previous bootm > command behavior (but behave better in the case where /chosen already > existed). I don't think the previous bootm behavior was ever desirable. In fact, I think most people didn't realize that boo

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-20 Thread Jerry Van Baren
Scott Wood wrote: > Jerry Van Baren wrote: >> Scott Wood wrote: >>> Kim Phillips wrote: The LIBFDT implementation replaces any existing /chosen with its fixed up version. >> >> Sort of. If /chosen doesn't exist, it creates it. >> >> If /chosen exists and "force" parameter is false, it do

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-20 Thread Scott Wood
Jerry Van Baren wrote: > Scott Wood wrote: >> Kim Phillips wrote: >>> The LIBFDT implementation replaces any existing /chosen with its fixed >>> up version. > > > Sort of. If /chosen doesn't exist, it creates it. > > If /chosen exists and "force" parameter is false, it doesn't touch it. > If "

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Jerry Van Baren
Scott Wood wrote: > Kim Phillips wrote: >> the old FLAT_TREE u-boot fdt fixup code renames any existing chosen >> node out of the way, and adds its fixed up version as /chosen. Not in my experience. My experience is that it blindly created a second /chosen node. >> The LIBFDT implementation rep

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Kim Phillips
On Thu, 19 Jul 2007 16:44:27 -0500 Scott Wood <[EMAIL PROTECTED]> wrote: > Kim Phillips wrote: > > the old FLAT_TREE u-boot fdt fixup code renames any existing chosen > > node out of the way, and adds its fixed up version as /chosen. > > > > The LIBFDT implementation replaces any existing /chosen

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Grant Likely
On 7/19/07, Kim Phillips <[EMAIL PROTECTED]> wrote: > On Thu, 19 Jul 2007 13:43:17 -0600 > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote: > > > Grant Likely wrote: > > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > > > To boot from a cuImag

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Scott Wood
Kim Phillips wrote: > the old FLAT_TREE u-boot fdt fixup code renames any existing chosen > node out of the way, and adds its fixed up version as /chosen. > > The LIBFDT implementation replaces any existing /chosen with its fixed > up version. Could you point out the code that does this? I don't

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Kim Phillips
On Thu, 19 Jul 2007 13:43:17 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote: > > Grant Likely wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > To boot from a cuImage requires the device tree to have a > > > linux,stdout-path proper

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Jerry Van Baren
Grant Likely wrote: > On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote: >> Grant Likely wrote: >>> From: Grant Likely <[EMAIL PROTECTED]> >>> >>> To boot from a cuImage requires the device tree to have a >>> linux,stdout-path property in the chosen node. This patch adds it >>> to the .dts files. >

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Grant Likely
On 7/19/07, Jerry Van Baren <[EMAIL PROTECTED]> wrote: > I think the "proper" solution is not to add the /chosen node in the dts > but rather to generate a _correct_ one in u-boot. Note that > linux,stdout-path is something that _should_ be generated based on the > u-boot configuration (currently

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Grant Likely
On 7/19/07, Scott Wood <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > To boot from a cuImage requires the device tree to have a > > linux,stdout-path property in the chosen node. This patch adds it > > to the .dts files. > > This will break many

[PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> To boot from a cuImage requires the device tree to have a linux,stdout-path property in the chosen node. This patch adds it to the .dts files. Signed-of-by: Grant Likely <[EMAIL PROTECTED]> CC: Scott Wood <[EMAIL PROTECTED]> CC: Kumar Gala <[EMAIL PROTECTED

Re: [PATCH 3/4] mpc8349emitx: Add chosen node for default stdout path

2007-07-19 Thread Scott Wood
Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > To boot from a cuImage requires the device tree to have a > linux,stdout-path property in the chosen node. This patch adds it > to the .dts files. This will break many current u-boots, as they blindly add a /chosen node regardless