Re: [PATCH 3/4] exit_thread: accept a task parameter to be exited

2016-03-24 Thread Russell King - ARM Linux
On Thu, Mar 24, 2016 at 01:58:13PM +0100, Jiri Slaby wrote: > We need to call exit_thread from copy_process in a fail path. So make > it accept task_struct as a parameter. Hmm, so what this means is that exit_thread() can now be called for threads which are not running on the CPU. So, I think th

Re: [PATCH 3/4] exit_thread: accept a task parameter to be exited

2016-03-24 Thread Peter Zijlstra
On Thu, Mar 24, 2016 at 01:58:13PM +0100, Jiri Slaby wrote: > void > -exit_thread(void) > +exit_thread(struct task_struct *me) > { > } task_struct arguments are called: tsk, task, p 'me' seems very wrong, as that could only mean 'current', and its clearly not that. _

Re: [PATCH 3/4] exit_thread: accept a task parameter to be exited

2016-03-24 Thread Jiri Slaby
On 03/24/2016, 02:03 PM, Peter Zijlstra wrote: > On Thu, Mar 24, 2016 at 01:58:13PM +0100, Jiri Slaby wrote: >> void >> -exit_thread(void) >> +exit_thread(struct task_struct *me) >> { >> } > > task_struct arguments are called: tsk, task, p > 'me' seems very wrong, as that could only mean 'curre

[PATCH 3/4] exit_thread: accept a task parameter to be exited

2016-03-24 Thread Jiri Slaby
We need to call exit_thread from copy_process in a fail path. So make it accept task_struct as a parameter. Signed-off-by: Jiri Slaby Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: Vineet Gupta Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: Haavard Skinnemoen Cc: