Re: [PATCH 3/4] Convert axon_msi to an of_platform driver

2008-02-04 Thread Benjamin Herrenschmidt
On Fri, 2008-01-25 at 16:59 +1100, Michael Ellerman wrote: > Now that we create of_platform devices earlier on cell, we can make the > axon_msi driver an of_platform driver. This makes the code cleaner in > several ways, and most importantly means we have a struct device. > > Signed-off-by: Micha

[PATCH 3/4] Convert axon_msi to an of_platform driver

2008-01-24 Thread Michael Ellerman
Now that we create of_platform devices earlier on cell, we can make the axon_msi driver an of_platform driver. This makes the code cleaner in several ways, and most importantly means we have a struct device. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/axon_

Re: [PATCH 3/4] Convert axon_msi to an of_platform driver

2008-01-22 Thread Stephen Rothwell
Hi Michael, On Tue, 22 Jan 2008 22:04:40 +1100 (EST) Michael Ellerman <[EMAIL PROTECTED]> wrote: > > +#include You must have missed the lectures :-) Please use linux/of_platform.h > +static struct of_device_id axon_msi_device_id[] = { const, please. -- Cheers, Stephen Rothwell

[PATCH 3/4] Convert axon_msi to an of_platform driver

2008-01-22 Thread Michael Ellerman
Now that we create of_platform devices earlier on cell, we can make the axon_msi driver an of_platform driver. This makes the code cleaner in several ways, and most importantly means we have a struct device. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/axon_