Re: [PATCH 3/3] tty: hvc_xen: hide xen_console_remove when unused

2016-01-26 Thread Stefano Stabellini
On Mon, 25 Jan 2016, Boris Ostrovsky wrote: > On 01/25/2016 04:54 PM, Arnd Bergmann wrote: > > xencons_disconnect_backend() is only called from xen_console_remove(), > > and also from xencons_probe()/xencons_resume(). But those two are also under > the > same ifdef. Good point. Aside from this th

Re: [PATCH 3/3] tty: hvc_xen: hide xen_console_remove when unused

2016-01-25 Thread Boris Ostrovsky
On 01/25/2016 04:54 PM, Arnd Bergmann wrote: xencons_disconnect_backend() is only called from xen_console_remove(), and also from xencons_probe()/xencons_resume(). But those two are also under the same ifdef. -boris which is conditionally compiled, so we get a harmless warning when CONFIG_

[PATCH 3/3] tty: hvc_xen: hide xen_console_remove when unused

2016-01-25 Thread Arnd Bergmann
xencons_disconnect_backend() is only called from xen_console_remove(), which is conditionally compiled, so we get a harmless warning when CONFIG_HVC_XEN_FRONTEND is unset: hvc/hvc_xen.c:350:12: error: 'xen_console_remove' defined but not used [-Werror=unused-function] This moves the function dow