Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-03-03 Thread Nathan Lynch
Michael Ellerman wrote: > On Thu, 2008-02-28 at 08:46 -0800, Badari Pulavarty wrote: > > Hotplug memory notifier for ppc64. This gets invoked by writing > > the device-node that needs to be removed to /proc/ppc64/ofdt. > > We need to adjust the sections and remove sysfs entries by > > calling __rem

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-03-02 Thread Michael Ellerman
On Fri, 2008-02-29 at 09:47 -0800, Badari Pulavarty wrote: > Index: linux-2.6.25-rc2/arch/powerpc/platforms/pseries/hotplug-memory.c > === > --- /dev/null 1970-01-01 00:00:00.0 + > +++ linux-2.6.25-rc2/arch/powerpc/platform

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-29 Thread Badari Pulavarty
Stephen Rothwell wrote: > On Fri, 29 Feb 2008 09:47:16 -0800 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > >> Here is the latest for review. (just to make sure I didn't miss >> anything). >> > > Sorry I didn't review the previous ones ... just a small thing. > > >> +type = of_get_pro

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-29 Thread Stephen Rothwell
On Fri, 29 Feb 2008 09:47:16 -0800 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > Here is the latest for review. (just to make sure I didn't miss > anything). Sorry I didn't review the previous ones ... just a small thing. > + type = of_get_property(np, "device_type", NULL); To use the of_

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-29 Thread Badari Pulavarty
On Fri, 2008-02-29 at 12:03 +1100, Michael Ellerman wrote: > On Thu, 2008-02-28 at 18:39 -0600, Nathan Lynch wrote: > > Michael Ellerman wrote: > > > On Thu, 2008-02-28 at 08:46 -0800, Badari Pulavarty wrote: > > > > Hotplug memory notifier for ppc64. This gets invoked by writing > > > > the device

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-28 Thread Michael Ellerman
On Thu, 2008-02-28 at 18:39 -0600, Nathan Lynch wrote: > Michael Ellerman wrote: > > On Thu, 2008-02-28 at 08:46 -0800, Badari Pulavarty wrote: > > > Hotplug memory notifier for ppc64. This gets invoked by writing > > > the device-node that needs to be removed to /proc/ppc64/ofdt. > > > We need to

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-28 Thread Michael Ellerman
On Thu, 2008-02-28 at 08:46 -0800, Badari Pulavarty wrote: > Hotplug memory notifier for ppc64. This gets invoked by writing > the device-node that needs to be removed to /proc/ppc64/ofdt. > We need to adjust the sections and remove sysfs entries by > calling __remove_pages(). Then call arch specif

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-28 Thread Badari Pulavarty
On Thu, 2008-02-28 at 11:20 -0600, Nathan Lynch wrote: > Badari Pulavarty wrote: > > > +static struct notifier_block pseries_smp_nb = { > > Rename this to pseries_mem_nb? Sure. > > > + .notifier_call = pseries_memory_notifier, > > +}; > > + > > +static int __init pseries_memory_hotplug_init(

Re: [PATCH 3/3] ppc64-specific memory notifier support

2008-02-28 Thread Nathan Lynch
Badari Pulavarty wrote: > +static struct notifier_block pseries_smp_nb = { Rename this to pseries_mem_nb? > + .notifier_call = pseries_memory_notifier, > +}; > + > +static int __init pseries_memory_hotplug_init(void) > +{ > + if (firmware_has_feature(FW_FEATURE_LPAR)) > + pSe

[PATCH 3/3] ppc64-specific memory notifier support

2008-02-28 Thread Badari Pulavarty
Hotplug memory notifier for ppc64. This gets invoked by writing the device-node that needs to be removed to /proc/ppc64/ofdt. We need to adjust the sections and remove sysfs entries by calling __remove_pages(). Then call arch specific code to get rid of htab mappings for the section of memory. Sig