Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-07 Thread Benjamin Herrenschmidt
On Thu, 2013-11-07 at 09:14 +0100, Alexander Graf wrote: > > And ? An explanation isn't going to be clearer than the code in that > > case ... > > It's pretty non-obvious when you do a git show on that patch in 1 year > from now, as the redundancy is out of scope of what the diff shows. And ? How

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-07 Thread Alexander Graf
Am 07.11.2013 um 08:55 schrieb Benjamin Herrenschmidt : > On Thu, 2013-11-07 at 08:52 +0100, Alexander Graf wrote: >> Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt >> : >> >>> On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: On 05.11.2013, at 08:42, Liu Ping Fan wrote: >

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Benjamin Herrenschmidt
On Thu, 2013-11-07 at 08:52 +0100, Alexander Graf wrote: > Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt > : > > > On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: > >> On 05.11.2013, at 08:42, Liu Ping Fan wrote: > >> > >>> Signed-off-by: Liu Ping Fan > >> > >> Patch descript

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Alexander Graf
Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt : > On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: >> On 05.11.2013, at 08:42, Liu Ping Fan wrote: >> >>> Signed-off-by: Liu Ping Fan >> >> Patch description missing. > > Do you really need a description for trivial one-lines w

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Benjamin Herrenschmidt
On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: > On 05.11.2013, at 08:42, Liu Ping Fan wrote: > > > Signed-off-by: Liu Ping Fan > > Patch description missing. Do you really need a description for trivial one-lines whose subject is a perfectly complete description already ? > Please

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Alexander Graf
On 05.11.2013, at 08:42, Liu Ping Fan wrote: > Signed-off-by: Liu Ping Fan Patch description missing. Please add Paul's ack in the next revision of this patch :). Alex > --- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-05 Thread Paul Mackerras
On Tue, Nov 05, 2013 at 03:42:44PM +0800, Liu Ping Fan wrote: > Signed-off-by: Liu Ping Fan > --- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c > b/arch/powerpc/kvm/book3s_64_mmu_hv.c > index 28160ac..7682837 10

[PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-04 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c index 28160ac..7682837 100644 --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c +++ b/arch/powerpc/kvm/book3s_6