Re: [PATCH 3/3] mmc: change .get_ro() callback semantics

2008-06-05 Thread Marc Pignat
On Thursday 05 June 2008, Anton Vorontsov wrote: > On Tue, Jun 03, 2008 at 12:07:49PM +0200, Marc Pignat wrote: > > Hi all! > > > > On Friday 23 May 2008, Anton Vorontsov wrote: > > > get_ro() callback must return values >= 0 for its logical state, and > > ... > > > static void pxamci_set_ios(str

Re: [PATCH 3/3] mmc: change .get_ro() callback semantics

2008-06-05 Thread Anton Vorontsov
On Tue, Jun 03, 2008 at 12:07:49PM +0200, Marc Pignat wrote: > Hi all! > > On Friday 23 May 2008, Anton Vorontsov wrote: > > get_ro() callback must return values >= 0 for its logical state, and > ... > > static void pxamci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > diff --git a/includ

Re: [PATCH 3/3] mmc: change .get_ro() callback semantics

2008-06-03 Thread Marc Pignat
Hi all! On Friday 23 May 2008, Anton Vorontsov wrote: > get_ro() callback must return values >= 0 for its logical state, and ... > static void pxamci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h > index f2e9885..ef3b773 1006

[PATCH 3/3] mmc: change .get_ro() callback semantics

2008-05-23 Thread Anton Vorontsov
get_ro() callback must return values >= 0 for its logical state, and negative errno values in case of error. If particular host instance doesn't support RO/WP switch, it should return -ENOSYS. This patch changes some hosts in two ways: 1. Now functions should be smart to not return negative valu

[PATCH 3/3] mmc: change .get_ro() callback semantics

2008-05-22 Thread Anton Vorontsov
get_ro() callback must return values >= 0 for its logical state, and negative errno values in case of error. If particular host instance doesn't support RO/WP switch, it should return -ENOSYS. This patch changes some hosts in two ways: 1. Now functions should be smart to not return negative valu