Re: [PATCH 2.6.35 & stable (v2)] powerpc: fix logic error in fixup_irqs

2010-06-11 Thread Johannes Berg
On Fri, 2010-06-11 at 22:55 +0200, Johannes Berg wrote: > When SPARSE_IRQ is set, irq_to_desc() can > return NULL. While the code here has a > check for NULL, it's not really correct. > Fix it by separating the check for it. Incidentally, there's another quirk in fixup_irqs(): ... alloc_c

[PATCH 2.6.35 & stable (v2)] powerpc: fix logic error in fixup_irqs

2010-06-11 Thread Johannes Berg
When SPARSE_IRQ is set, irq_to_desc() can return NULL. While the code here has a check for NULL, it's not really correct. Fix it by separating the check for it. This fixes CPU hot unplug for me. Reported-by: Alastair Bridgewater Cc: sta...@kernel.org Signed-off-by: Johannes Berg --- v2: cc Alas