Re: [PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable()

2013-07-09 Thread Michael Ellerman
On Tue, Jul 09, 2013 at 05:15:23PM -0700, Sukadev Bhattiprolu wrote: > Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: > | On 06/24/2013 04:58 PM, Michael Ellerman wrote: > | > In pmu_disable() we disable the PMU by setting the FC (Freeze Counters) > | > bit in MMCR0. In order to do this we

Re: [PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable()

2013-07-09 Thread Sukadev Bhattiprolu
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote: | On 06/24/2013 04:58 PM, Michael Ellerman wrote: | > In pmu_disable() we disable the PMU by setting the FC (Freeze Counters) | > bit in MMCR0. In order to do this we have to read/modify/write MMCR0. | > | > It's possible that we read a value

Re: [PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable()

2013-06-25 Thread Michael Ellerman
On Tue, Jun 25, 2013 at 04:52:39PM +0530, Anshuman Khandual wrote: > On 06/24/2013 04:58 PM, Michael Ellerman wrote: > > In pmu_disable() we disable the PMU by setting the FC (Freeze Counters) > > bit in MMCR0. In order to do this we have to read/modify/write MMCR0. > > > > It's possible that we r

Re: [PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable()

2013-06-25 Thread Anshuman Khandual
On 06/24/2013 04:58 PM, Michael Ellerman wrote: > In pmu_disable() we disable the PMU by setting the FC (Freeze Counters) > bit in MMCR0. In order to do this we have to read/modify/write MMCR0. > > It's possible that we read a value from MMCR0 which has PMAO (PMU Alert > Occurred) set. When we wri

[PATCH 2/8] powerpc/perf: Rework disable logic in pmu_disable()

2013-06-24 Thread Michael Ellerman
In pmu_disable() we disable the PMU by setting the FC (Freeze Counters) bit in MMCR0. In order to do this we have to read/modify/write MMCR0. It's possible that we read a value from MMCR0 which has PMAO (PMU Alert Occurred) set. When we write that value back it will cause an interrupt to occur. We