Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-17 Thread Arnd Bergmann
On Thursday 17 January 2008, Paul Gortmaker wrote: > +struct serial_parent { > +   char *type; > +   char *compat; > +}; > + > +static struct __init serial_parent parents[] = { > +   {"soc", NULL}, > +   {"tsi-bridge", NULL}, > +   {"opb", "ibm,opb"}, > +   {NULL, "wrs,epld-

Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-17 Thread Scott Wood
Paul Gortmaker wrote: > +static struct __init serial_parent parents[] = { > + {"soc", NULL}, > + {"tsi-bridge", NULL}, > + {"opb", "ibm,opb"}, > + {NULL, "wrs,epld-localbus"}, > +}; can we add {NULL, "simple-bus"} to this list? -Scott __

Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-17 Thread Paul Gortmaker
In message: Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device on 07/01/2008 Arnd Bergmann wrote: > On Monday 07 January 2008, Paul Gortmaker wrote: > > > > I'd thought about doing that, but there are slight differences > > in each test

Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-07 Thread Arnd Bergmann
On Monday 07 January 2008, Paul Gortmaker wrote: > > I'd thought about doing that, but there are slight differences > in each test.  To remain 100% faithful to the original implementation > you'd have to have a table or similar that had these various fields > and loop over that -- something like:

Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-07 Thread Paul Gortmaker
Arnd Bergmann wrote: > On Monday 07 January 2008, Paul Gortmaker wrote: > >> + /* Next, fill our array with any localbus serial ports */ >> + for_each_compatible_node(np, "serial", "ns16550") { >> + struct device_node *lbs = of_get_parent(np); >> + if (lbs

Re: [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-07 Thread Arnd Bergmann
On Monday 07 January 2008, Paul Gortmaker wrote: > +   /* Next, fill our array with any localbus serial ports */ > +   for_each_compatible_node(np, "serial", "ns16550") { > +   struct device_node *lbs = of_get_parent(np); > +   if (lbs && of_device_is_compatible(lbs,

[PATCH 2/7] powerpc: allow localbus compatible serial ports for console device

2008-01-07 Thread Paul Gortmaker
Add to legacy_serial the ability to use any ns16550 compatible UART with a parent that is compatible with "localbus" as the console device. Signed-off-by: Paul Gortmaker <[EMAIL PROTECTED]> --- arch/powerpc/kernel/legacy_serial.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(