On Thu, Sep 20, 2007 at 09:35:10AM -0700, john stultz wrote:
> I think what Daniel is pointing out is that the clocksource read
> function isn't the place for the __USE_RTC() conditional.
>
> It would likely be better instead of the timebase clocksource managing
> multiple type of hardware (tim
On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote:
> Daniel Walker writes:
>
> > If you switch to the rtc do the shift and mult need to change?
>
> You can't switch; any given CPU chip will have either the RTC or the
> timebase but not both.
I think what Daniel is pointing out is that the
On Thu, 2007-09-20 at 13:29 +1000, David Gibson wrote:
> > Maybe say "It a constant" up front .. The value that is output from the
> > clocksource read is converted to nanoseconds .. This clocksource is only
> > designed to work with the timebase, so it doesn't make sense to output
> > an rtc valu
On Wed, Sep 19, 2007 at 06:54:41PM -0700, Daniel Walker wrote:
> On Thu, 2007-09-20 at 11:46 +1000, Paul Mackerras wrote:
> > Daniel Walker writes:
> >
> > > On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote:
> > > > Daniel Walker writes:
> > > >
> > > > > If you switch to the rtc do the sh
On Thu, 2007-09-20 at 11:46 +1000, Paul Mackerras wrote:
> Daniel Walker writes:
>
> > On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote:
> > > Daniel Walker writes:
> > >
> > > > If you switch to the rtc do the shift and mult need to change?
> > >
> > > You can't switch; any given CPU chi
Daniel Walker writes:
> On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote:
> > Daniel Walker writes:
> >
> > > If you switch to the rtc do the shift and mult need to change?
> >
> > You can't switch; any given CPU chip will have either the RTC or the
> > timebase but not both.
>
> The cod
On Thu, 2007-09-20 at 10:52 +1000, Paul Mackerras wrote:
> Daniel Walker writes:
>
> > If you switch to the rtc do the shift and mult need to change?
>
> You can't switch; any given CPU chip will have either the RTC or the
> timebase but not both.
The code is switching between to clock read func
Daniel Walker writes:
> If you switch to the rtc do the shift and mult need to change?
You can't switch; any given CPU chip will have either the RTC or the
timebase but not both.
> > + /* XXX this assumes clock->shift == 22 */
> > + /* 4611686018 ~= 2^(20+64-22) / 1e9 */
> > +
On Wed, 2007-09-19 at 16:49 +1000, Tony Breeds wrote:
> +/* clocksource code */
> +/* FIXME: provide an RTC clocksource /or/ use a better name */
> +static cycle_t timebase_read(void)
> +{
> + if (__USE_RTC())
> + return (cycle_t)get_rtc();
> + return (cycle_t)get_tb();
>
Signed-off-by: Tony Breeds <[EMAIL PROTECTED]>
---
arch/powerpc/Kconfig |6
arch/powerpc/kernel/time.c | 255 -
2 files changed, 91 insertions(+), 170 deletions(-)
Index: working/arch/powerpc/Kconfig
===
10 matches
Mail list logo