Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread David Brownell
On Wednesday 24 September 2008, Anton Vorontsov wrote: > > Anyway, just want to thank you for your time and persistence on this > matter, you're forcing others' people brains to *work*. And since you > rejected this approach too, I have no other option but to implement > something else... someth

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread Anton Vorontsov
On Wed, Sep 24, 2008 at 11:54:24AM -0700, David Brownell wrote: [...] > You'd be better off calling something other than of_get_gpio() > for those three pins in of_fhci_probe() ... call something > that returns a "qe_pin" structure (e.g. wrapping an instance of > the misnamed qe_gpio_chip plus an o

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread David Brownell
On Tuesday 23 September 2008, Anton Vorontsov wrote: > qe_gpio_set_dedicated() is a platform specific function, which is used > to revert a pin to a dedicated function. Caller should have already > obtained the gpio via gpio_request(). Note the missing sibling function: putting the pin back into

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread David Brownell
On Wednesday 24 September 2008, Anton Vorontsov wrote: > > what do you mean by dedicated function.. be a bit clearer in the commit > > log. > > This term is from the QE spec, I didn't invent anything. ;-) > > "Each pin in the I/O ports can be configured as a general-purpose > I/O signal or as a

[PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread Anton Vorontsov
qe_gpio_set_dedicated() is a platform specific function that is used to revert a pin to a dedicated on chip peripheral function. Caller should have already obtained the gpio via gpio_request(). This is needed to support Freescale USB Host Controller. Signed-off-by: Anton Vorontsov <[EMAIL PROTECT

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread Anton Vorontsov
On Wed, Sep 24, 2008 at 09:00:03AM -0500, Kumar Gala wrote: > > On Sep 24, 2008, at 6:42 AM, Anton Vorontsov wrote: > >> On Tue, Sep 23, 2008 at 11:07:00PM -0500, Kumar Gala wrote: >>> >>> On Sep 23, 2008, at 7:03 PM, Anton Vorontsov wrote: >>> qe_gpio_set_dedicated() is a platform specific fu

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread Kumar Gala
On Sep 24, 2008, at 6:42 AM, Anton Vorontsov wrote: On Tue, Sep 23, 2008 at 11:07:00PM -0500, Kumar Gala wrote: On Sep 23, 2008, at 7:03 PM, Anton Vorontsov wrote: qe_gpio_set_dedicated() is a platform specific function, which is used to revert a pin to a dedicated function. Caller should

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-24 Thread Anton Vorontsov
On Tue, Sep 23, 2008 at 11:07:00PM -0500, Kumar Gala wrote: > > On Sep 23, 2008, at 7:03 PM, Anton Vorontsov wrote: > >> qe_gpio_set_dedicated() is a platform specific function, which is used >> to revert a pin to a dedicated function. Caller should have already >> obtained the gpio via gpio_reques

Re: [PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-23 Thread Kumar Gala
On Sep 23, 2008, at 7:03 PM, Anton Vorontsov wrote: qe_gpio_set_dedicated() is a platform specific function, which is used to revert a pin to a dedicated function. Caller should have already obtained the gpio via gpio_request(). This is needed to support Freescale USB Host Controller. Signed-

[PATCH 2/4] powerpc/qe: new call to revert a gpio to a dedicated function

2008-09-23 Thread Anton Vorontsov
qe_gpio_set_dedicated() is a platform specific function, which is used to revert a pin to a dedicated function. Caller should have already obtained the gpio via gpio_request(). This is needed to support Freescale USB Host Controller. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/po