Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-19 Thread Brian King
Ragner Magalhaes wrote: > ext Brian King wrote: >> Ragner Magalhaes wrote: >>> here also, as above ... + if (data && (dev->features & NETIF_F_IP_CSUM)) + return 0; + if (!data && !(dev->features & NETIF_F_IP_CSUM)) + return 0; >> This change would make the li

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-19 Thread Ragner Magalhaes
ext Brian King wrote: > Ragner Magalhaes wrote: >> ext Brian King wrote: >> >>> + >>> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data) >>> +{ >>> + struct ibmveth_adapter *adapter = dev->priv; >>> + >> Why do not to do >> >> if ((data && adapter->rx_csum) || (!data && !adapt

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-19 Thread Brian King
Ragner Magalhaes wrote: > ext Brian King wrote: > >> + >> +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data) >> +{ >> +struct ibmveth_adapter *adapter = dev->priv; >> + > > Why do not to do > > if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum)) >

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-19 Thread Ragner Magalhaes
ext Brian King wrote: > + > +static int ibmveth_set_rx_csum(struct net_device *dev, u32 data) > +{ > + struct ibmveth_adapter *adapter = dev->priv; > + Why do not to do if ((data && adapter->rx_csum) || (!data && !adapter->rx_csum)) return 0; less two lines. > +

[PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-19 Thread Brian King
This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++- linux-2.6-bjking1/drivers/net/ibmveth

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: > This patch adds the appropriate ethtool hooks to allow for enabling/disabling > of hypervisor assisted checksum offload for TCP. > > Signed-off-by: Brian King <[EMAIL PROTECTED]> > --- > > linux-2.6-bjking1/drivers/net/ibmveth.c | 120 > +++- > l

[PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-17 Thread Brian King
This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++- linux-2.6-bjking1/drivers/net/ibmveth