Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-24 Thread Segher Boessenkool
>> Nothing in a flat device tree should ever define a device_type, except >> perhaps for compatibility with legacy kernel code. > > This is not necessarily true. As Segher says, device_type originally > indicated the OF programming model for a device. However, we've > extended the notion for the

Re: [linux-usb-devel] [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-24 Thread Valentine Barshak
Valentine Barshak wrote: > Segher Boessenkool wrote: > + Required properties: > + - device_type : should be "usb". No device_type please. The published USB binding doesn't define one on purpose. >>> Could you please, explain why? >>> Sorry, I don't think I get the concept of de

[PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-24 Thread Valentine Barshak
Adds EHCI OF bindings to documentation. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 28 +++ 1 files changed, 28 insertions(+) diff -ruN linux-2.6.orig/Documentation/powerpc/booting-without-of.txt linux-2.6/Doc

Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-19 Thread David Gibson
On Wed, Sep 19, 2007 at 06:50:02PM +0200, Segher Boessenkool wrote: > >>> + Required properties: > >>> + - device_type : should be "usb". > >> No device_type please. The published USB binding doesn't define > >> one on purpose. > > > > Could you please, explain why? > > Sorry, I don't think I ge

Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-19 Thread Valentine Barshak
Segher Boessenkool wrote: + Required properties: + - device_type : should be "usb". >>> No device_type please. The published USB binding doesn't define >>> one on purpose. >> >> Could you please, explain why? >> Sorry, I don't think I get the concept of device description here. > > "d

Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-19 Thread Segher Boessenkool
>>> + Required properties: >>> + - device_type : should be "usb". >> No device_type please. The published USB binding doesn't define >> one on purpose. > > Could you please, explain why? > Sorry, I don't think I get the concept of device description here. "device_type" is meant to be used only

Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-19 Thread Valentine Barshak
Segher Boessenkool wrote: >> + l) USB EHCI controllers >> + >> + Required properties: >> + - device_type : should be "usb". > > No device_type please. The published USB binding doesn't define > one on purpose. > Could you please, explain why? Sorry, I don't think I get the concept of device

Re: [PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-18 Thread Segher Boessenkool
> + l) USB EHCI controllers > + > + Required properties: > + - device_type : should be "usb". No device_type please. The published USB binding doesn't define one on purpose. > + - compatible : should be "ehci". Just "ehci" isn't enough -- compare to OHCI, which is the name for a kind of USB

[PATCH 2/3] usb: ehci-ppc-of dts bindings.

2007-09-17 Thread Valentine Barshak
Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- Documentation/powerpc/booting-without-of.txt | 30 +++ 1 file changed, 30 insertions(+) diff -ruN linux-2.6.orig/Documentation/powerpc/booting-without-of.txt linux-2.6.new/Documentation/powerpc/booting-without-of.