Re: [PATCH 2/3] powerpc: fix build errors

2022-02-25 Thread Nicholas Piggin
Excerpts from Segher Boessenkool's message of February 26, 2022 8:28 am: > On Fri, Feb 25, 2022 at 10:23:07AM +1000, Nicholas Piggin wrote: >> Excerpts from Segher Boessenkool's message of February 25, 2022 3:29 am: >> > On Thu, Feb 24, 2022 at 09:13:25PM +1000, Nicholas Piggin wrote: >> >> Excerpt

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-25 Thread Segher Boessenkool
On Fri, Feb 25, 2022 at 10:32:02AM +1000, Nicholas Piggin wrote: > Excerpts from Segher Boessenkool's message of February 25, 2022 3:12 am: > > On Thu, Feb 24, 2022 at 03:05:28PM +1000, Nicholas Piggin wrote: > >> + * gcc 10 started to emit a .machine directive at the beginning of > >> generated >

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-25 Thread Segher Boessenkool
On Fri, Feb 25, 2022 at 10:23:07AM +1000, Nicholas Piggin wrote: > Excerpts from Segher Boessenkool's message of February 25, 2022 3:29 am: > > On Thu, Feb 24, 2022 at 09:13:25PM +1000, Nicholas Piggin wrote: > >> Excerpts from Arnd Bergmann's message of February 24, 2022 8:20 pm: > >> > Again, the

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-25 Thread Nicholas Piggin
Excerpts from Arnd Bergmann's message of February 25, 2022 6:33 pm: > On Fri, Feb 25, 2022 at 1:32 AM Nicholas Piggin wrote: >> Excerpts from Segher Boessenkool's message of February 25, 2022 3:12 am: >> >> +#ifdef CONFIG_CC_IS_GCC >> >> +#if (GCC_VERSION >= 10) >> >> +#if (CONFIG_AS_VERSION =

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-25 Thread Arnd Bergmann
On Fri, Feb 25, 2022 at 1:32 AM Nicholas Piggin wrote: > Excerpts from Segher Boessenkool's message of February 25, 2022 3:12 am: > >> +#ifdef CONFIG_CC_IS_GCC > >> +#if (GCC_VERSION >= 10) > >> +#if (CONFIG_AS_VERSION == 23800) > >> +asm(".machine any"); > >> +#endif > >> +#endif > >> +#endif

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Segher Boessenkool's message of February 25, 2022 3:12 am: > On Thu, Feb 24, 2022 at 03:05:28PM +1000, Nicholas Piggin wrote: >> + * gcc 10 started to emit a .machine directive at the beginning of generated >> + * .s files, which overrides assembler -Wa,-m options passed down. >> + *

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Segher Boessenkool's message of February 25, 2022 3:29 am: > On Thu, Feb 24, 2022 at 09:13:25PM +1000, Nicholas Piggin wrote: >> Excerpts from Arnd Bergmann's message of February 24, 2022 8:20 pm: >> > Again, there should be a minimum number of those .machine directives >> > in inline

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Segher Boessenkool
On Thu, Feb 24, 2022 at 11:39:16PM +1100, Michael Ellerman wrote: > > /* Calculate the parity of the value */ > > - asm ("popcntd %0,%1" : "=r" (parity) : "r" (val)); > > + asm (".machine \"push\"\n" > > +".machine \"power7\"\n" > > +"popcntd %0,%1\n" > > +".machine

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Segher Boessenkool
On Thu, Feb 24, 2022 at 09:13:25PM +1000, Nicholas Piggin wrote: > Excerpts from Arnd Bergmann's message of February 24, 2022 8:20 pm: > > Again, there should be a minimum number of those .machine directives > > in inline asm as well, which tends to work out fine as long as the > > entire kernel is

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Segher Boessenkool
On Thu, Feb 24, 2022 at 03:05:28PM +1000, Nicholas Piggin wrote: > + * gcc 10 started to emit a .machine directive at the beginning of generated > + * .s files, which overrides assembler -Wa,-m options passed down. > + * Unclear if this behaviour will be reverted. It will not be reverted. If you

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Anders Roxell
On Thu, 24 Feb 2022 at 13:39, Michael Ellerman wrote: > > Hi Anders, Hi Michael, > > Thanks for these, just a few comments below ... I will resolve the comments below and resend a v2 shortly. Cheers, Anders > > Anders Roxell writes: > > Building tinyconfig with gcc (Debian 11.2.0-16) and ass

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Michael Ellerman
Hi Anders, Thanks for these, just a few comments below ... Anders Roxell writes: > Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian > 2.37.90.20220207) the following build error shows up: > > {standard input}: Assembler messages: > {standard input}:1190: Error: unrecognize

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Arnd Bergmann's message of February 24, 2022 8:20 pm: > On Thu, Feb 24, 2022 at 11:11 AM Nicholas Piggin wrote: >> Excerpts from Arnd Bergmann's message of February 24, 2022 6:55 pm: >> > On Thu, Feb 24, 2022 at 6:05 AM Nicholas Piggin wrote: >> > We had the same thing on Arm a few

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Arnd Bergmann
On Thu, Feb 24, 2022 at 11:11 AM Nicholas Piggin wrote: > Excerpts from Arnd Bergmann's message of February 24, 2022 6:55 pm: > > On Thu, Feb 24, 2022 at 6:05 AM Nicholas Piggin wrote: > > We had the same thing on Arm a few years ago when binutils > > started enforcing this more strictly, and it

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Arnd Bergmann's message of February 24, 2022 6:55 pm: > On Thu, Feb 24, 2022 at 6:05 AM Nicholas Piggin wrote: >> Excerpts from Nicholas Piggin's message of February 24, 2022 12:54 pm: >> > >> > Not sure on the outlook for GCC fix. Either way unfortunately we have >> > toolchains in

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Arnd Bergmann
On Thu, Feb 24, 2022 at 6:05 AM Nicholas Piggin wrote: > Excerpts from Nicholas Piggin's message of February 24, 2022 12:54 pm: > > > > Not sure on the outlook for GCC fix. Either way unfortunately we have > > toolchains in the wild now that will explode, so we might have to take > > your patches

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Anders Roxell's message of February 23, 2022 11:58 pm: > Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian > 2.37.90.20220207) the following build error shows up: > > {standard input}: Assembler messages: > {standard input}:1190: Error: unrecognized opcode: `stb

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-24 Thread Nicholas Piggin
Excerpts from Nicholas Piggin's message of February 24, 2022 12:54 pm: > Excerpts from Anders Roxell's message of February 23, 2022 11:58 pm: >> Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian >> 2.37.90.20220207) the following build error shows up: >> >> {standard input}: A

Re: [PATCH 2/3] powerpc: fix build errors

2022-02-23 Thread Segher Boessenkool
Hi! On Wed, Feb 23, 2022 at 02:58:19PM +0100, Anders Roxell wrote: > Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian > 2.37.90.20220207) the following build error shows up: > > {standard input}: Assembler messages: > {standard input}:1190: Error: unrecognized opcode: `stbc

[PATCH 2/3] powerpc: fix build errors

2022-02-23 Thread Anders Roxell
Building tinyconfig with gcc (Debian 11.2.0-16) and assembler (Debian 2.37.90.20220207) the following build error shows up: {standard input}: Assembler messages: {standard input}:1190: Error: unrecognized opcode: `stbcix' {standard input}:1433: Error: unrecognized opcode: `lwzcix' {standard in